From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>,
Hans Holmberg <hans.holmberg@wdc.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: prevent gc from picking the same zone twice
Date: Thu, 23 Oct 2025 17:04:08 +0200 [thread overview]
Message-ID: <20251023150408.GA30853@lst.de> (raw)
In-Reply-To: <20251023150232.GI4015566@frogsfrogsfrogs>
On Thu, Oct 23, 2025 at 08:02:32AM -0700, Darrick J. Wong wrote:
> > > > + *
> > > > + * This prevents us from picking one of the zones for which we
> > > > + * already submitted GC I/O, but for which the remapping hasn't
> > > > + * concluded again. This won't cause data corruption, but
> > >
> > > "...but that I/O hasn't yet finished."
> >
> > It's really the remapping after the I/O that has to finish, but given
> > that we talk about I/O earlier, maybe your wording is less confusing.
>
> The word 'again' at the end of the sentence tripped me up. I think the
> word you want there is "yet" (because "again" implies that this isn't
> the first time we've remapped the space, which isn't true) but you could
> also end the sentence wit` "concluded".
Both sounds fine.
next prev parent reply other threads:[~2025-10-23 15:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 6:07 fix for selecting a zone with active GC I/O for GC Christoph Hellwig
2025-10-17 6:07 ` [PATCH 1/2] xfs: prevent gc from picking the same zone twice Christoph Hellwig
2025-10-17 12:37 ` Carlos Maiolino
2025-10-20 11:49 ` Christoph Hellwig
2025-10-18 4:08 ` Damien Le Moal
2025-10-23 6:16 ` Darrick J. Wong
2025-10-23 6:28 ` Christoph Hellwig
2025-10-23 15:02 ` Darrick J. Wong
2025-10-23 15:04 ` Christoph Hellwig [this message]
2025-10-17 6:07 ` [PATCH 2/2] xfs: document another racy GC case in xfs_zoned_map_extent Christoph Hellwig
2025-10-17 12:40 ` Carlos Maiolino
2025-10-18 4:09 ` Damien Le Moal
2025-10-20 8:19 ` Hans Holmberg
2025-10-23 6:21 ` Darrick J. Wong
2025-10-23 6:30 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2025-10-23 15:17 fix for selecting a zone with active GC I/O for GC v2 Christoph Hellwig
2025-10-23 15:17 ` [PATCH 1/2] xfs: prevent gc from picking the same zone twice Christoph Hellwig
2025-10-31 11:19 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023150408.GA30853@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.