From: Jakub Kicinski <kuba@kernel.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: Adrian Moreno <amorenoz@redhat.com>,
netdev@vger.kernel.org, toke@redhat.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Xiao Liang <shaw.leon@gmail.com>,
Cong Wang <cong.wang@bytedance.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] rtnetlink: honor RTEXT_FILTER_SKIP_STATS in IFLA_STATS
Date: Thu, 23 Oct 2025 17:33:12 -0700 [thread overview]
Message-ID: <20251023173312.7e0ad8ff@kernel.org> (raw)
In-Reply-To: <6a2072e1-43be-49a3-b612-d6e2714ec63e@6wind.com>
On Thu, 23 Oct 2025 17:39:09 +0200 Nicolas Dichtel wrote:
> > + if (~ext_filter_mask & RTEXT_FILTER_SKIP_STATS &&
> Maybe parentheses around this first condition?
>
> The size could be adjusted accordingly in if_nlmsg_size().
Slight preference here for no brackets unless compiler complains
(or needed for correctness, of course).
next prev parent reply other threads:[~2025-10-24 0:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 8:34 [PATCH net-next] rtnetlink: honor RTEXT_FILTER_SKIP_STATS in IFLA_STATS Adrian Moreno
2025-10-23 15:39 ` Nicolas Dichtel
2025-10-24 0:33 ` Jakub Kicinski [this message]
2025-10-24 7:05 ` Adrián Moreno
2025-10-24 7:17 ` Nicolas Dichtel
2025-10-24 14:20 ` Toke Høiland-Jørgensen
2025-10-24 14:35 ` Eric Dumazet
2025-10-24 14:59 ` Nicolas Dichtel
2025-10-24 15:24 ` Adrián Moreno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023173312.7e0ad8ff@kernel.org \
--to=kuba@kernel.org \
--cc=amorenoz@redhat.com \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shaw.leon@gmail.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.