From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
Cc: Jonathan Cameron <jic23@kernel.org>, <dlechner@baylibre.com>,
<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<nuno.sa@analog.com>, <andy@kernel.org>,
<marcelo.schmitt1@gmail.com>, <vassilisamir@gmail.com>,
<salah.triki@gmail.com>, <skhan@linuxfoundation.org>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <akhileshpatilvnit@gmail.com>
Subject: Re: [PATCH v2 2/2] iio: pressure: adp810: Add driver for adp810 sensor
Date: Thu, 23 Oct 2025 18:25:37 +0100 [thread overview]
Message-ID: <20251023182537.000069be@huawei.com> (raw)
In-Reply-To: <20251021-54542-354166@bhairav-test.ee.iitb.ac.in>
On Tue, 21 Oct 2025 11:15:42 +0530
Akhilesh Patil <akhilesh@ee.iitb.ac.in> wrote:
> On Sat, Oct 18, 2025 at 05:47:46PM +0100, Jonathan Cameron wrote:
> > On Mon, 13 Oct 2025 22:32:35 +0530
> > Akhilesh Patil <akhilesh@ee.iitb.ac.in> wrote:
> >
> > > Add driver for Aosong adp810 differential pressure and temperature sensor.
> > > This sensor provides an I2C interface for reading data.
> > > Calculate CRC of the data received using standard crc8 library to verify
> > > data integrity.
> > >
> > > Tested on TI am62x sk board with sensor connected at i2c-2.
> > >
> > > Signed-off-by: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
> >
> > A few comments inline and it seems your rebase when wrong and you've
> > picked up unrelated build file changes.
> >
> > Thanks
> >
> > Jonathan
>
> Hi Jonathan, Thanks for the review, I will share v3 addressing these comments.
>
> Regards,
> Akhilesh
>
> >
> > > diff --git a/drivers/iio/pressure/Makefile b/drivers/iio/pressure/Makefile
> > > index 6482288e07ee..a21443e992b9 100644
> > > --- a/drivers/iio/pressure/Makefile
> > > +++ b/drivers/iio/pressure/Makefile
> > > @@ -5,6 +5,7 @@
> > >
> > > # When adding new entries keep the list in alphabetical order
> > > obj-$(CONFIG_ABP060MG) += abp060mg.o
> > > +obj-$(CONFIG_ADP810) += adp810.o
> > > obj-$(CONFIG_ROHM_BM1390) += rohm-bm1390.o
> > > obj-$(CONFIG_BMP280) += bmp280.o
> > > bmp280-objs := bmp280-core.o bmp280-regmap.o
> > > @@ -15,6 +16,7 @@ obj-$(CONFIG_DPS310) += dps310.o
> > > obj-$(CONFIG_IIO_CROS_EC_BARO) += cros_ec_baro.o
> > > obj-$(CONFIG_HID_SENSOR_PRESS) += hid-sensor-press.o
> > > obj-$(CONFIG_HP03) += hp03.o
> > > +obj-$(CONFIG_HP206C) += hp206c.o
> > > obj-$(CONFIG_HSC030PA) += hsc030pa.o
> > > obj-$(CONFIG_HSC030PA_I2C) += hsc030pa_i2c.o
> > > obj-$(CONFIG_HSC030PA_SPI) += hsc030pa_spi.o
> > > @@ -34,11 +36,9 @@ obj-$(CONFIG_SDP500) += sdp500.o
> > > obj-$(CONFIG_IIO_ST_PRESS) += st_pressure.o
> > > st_pressure-y := st_pressure_core.o
> > > st_pressure-$(CONFIG_IIO_BUFFER) += st_pressure_buffer.o
> > > +obj-$(CONFIG_IIO_ST_PRESS_I2C) += st_pressure_i2c.o
> > > +obj-$(CONFIG_IIO_ST_PRESS_SPI) += st_pressure_spi.o
> > > obj-$(CONFIG_T5403) += t5403.o
> > > -obj-$(CONFIG_HP206C) += hp206c.o
> >
> > Rebase gone wrong I assume.
>
> These are intentional changes.
>
> This addresses Andy's suggestion in v1, to keep entries alphabetically
> arranged in Makefile. Along with adp810 location, fixed other files as well
> hp206 and st_pressure_* to make entries alphabetically arranged in
> the entire Makefile.
That reorder of others needs to be a separate patch so that it can
explicitly call out that it is tidying up ordering.
Jonathan
prev parent reply other threads:[~2025-10-23 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 17:01 [PATCH v2 0/2] iio: pressure: add driver and bindings for adp810 Akhilesh Patil
2025-10-13 17:02 ` [PATCH v2 1/2] dt-bindings: iio: pressure: Add Aosong adp810 Akhilesh Patil
2025-10-13 17:02 ` [PATCH v2 2/2] iio: pressure: adp810: Add driver for adp810 sensor Akhilesh Patil
2025-10-18 16:47 ` Jonathan Cameron
2025-10-21 5:45 ` Akhilesh Patil
2025-10-23 17:25 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023182537.000069be@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=akhilesh@ee.iitb.ac.in \
--cc=akhileshpatilvnit@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=salah.triki@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.