All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: prc@list.ti.com
Cc: Denys Dmytriyenko <denys@konsulko.com>, meta-ti@lists.yoctoproject.org
Subject: Re: [meta-ti] [master][PATCH] packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set
Date: Thu, 23 Oct 2025 16:16:25 -0400	[thread overview]
Message-ID: <20251023201625.GA3125@denix.org> (raw)
In-Reply-To: <20251023181525.3536647-1-prc@list.ti.com>

Hey, Ryan,

Something is wrong with PRC...


On Thu, Oct 23, 2025 at 01:15:25PM -0500, PRC Automation via lists.yoctoproject.org wrote:
> meta-ti / na / 20251023181013.25365-1-denis
> 
> PRC Results: FAIL
> 
> =========================================================
>   check-yocto-patches: PASS
> =========================================================
> Patches
> ----------------------------------------
> WARN - [master][PATCH] packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set
>     WARN: Commit message does not include file/recipe name: packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set. (COMMIT-MESSAGE-2)

Well, packagegroup-ti-core-initramfs is actually the name of the recipe.


> =========================================================
>   check-yocto-repo: FAIL
> =========================================================
> master
> =====================
> FAIL
>     WARN: You might need a " " as the first character for the :append. (APPEND-2)
>         meta-ti-bsp/conf/machine/include/am62axx.inc:15
>             TI_INITRAMFS_KERNEL_MODULES:append:bsp-mainline  = "kernel-module-tps6594-i2c"
>     
>     WARN: You might need a " " as the first character for the :append. (APPEND-2)
>         meta-ti-bsp/conf/machine/include/am62axx.inc:16
>             TI_INITRAMFS_KERNEL_MODULES:append:bsp-next  = "kernel-module-tps6594-i2c"

This is not in my patch, but is a valid concern - need to correct it for 
am62axx.inc, while other machines appending to this variable already use a 
leading space...

>     
>     
>     Code Summary
>     ============
>     
>     APPEND-2
>     -------------------------------------------
>       :append simply takes the specified string and concatenates it
>       directly to the variable.  Most of the time we want there to spaces
>       between entries.  This check flags us to check if the missing space
>       is actually needed.
> 
> 
> 


  reply	other threads:[~2025-10-23 20:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-23 18:10 [master][PATCH] packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set Denys Dmytriyenko
2025-10-23 18:15 ` PRC Automation
2025-10-23 20:16   ` Denys Dmytriyenko [this message]
2025-10-24 16:22     ` [EXTERNAL] Re: [meta-ti] " Ryan Eatmon
2025-10-24 15:34 ` Ryan Eatmon
2025-10-24 15:50   ` Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251023201625.GA3125@denix.org \
    --to=denis@denix.org \
    --cc=denys@konsulko.com \
    --cc=meta-ti@lists.yoctoproject.org \
    --cc=prc@list.ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.