[jolsa-perf:bpf/single_direct_ops 6/9] samples/ftrace/ftrace-direct-multi.c:228:16: error: too few arguments to function 'register_ftrace_direct'

[kernel test robot <lkp@intel.com>]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git bpf/single_direct_ops
head:   3d31a310468694e4395d61e15c65edaa618fbb5c
commit: 1e0ad55e88bddb17e85b4b7c4ba933f3b98ecca0 [6/9] ftrace: Use direct hash interface in direct functions
config: x86_64-randconfig-121-20251023 (https://download.01.org/0day-ci/archive/20251023/202510232105.FcQpUN0T-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251023/202510232105.FcQpUN0T-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510232105.FcQpUN0T-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   samples/ftrace/ftrace-direct-multi.c: In function 'ftrace_direct_multi_init':
>> samples/ftrace/ftrace-direct-multi.c:228:16: error: too few arguments to function 'register_ftrace_direct'
     228 |         return register_ftrace_direct(&direct, (unsigned long) my_tramp);
         |                ^~~~~~~~~~~~~~~~~~~~~~
   In file included from samples/ftrace/ftrace-direct-multi.c:5:
   include/linux/ftrace.h:539:5: note: declared here
     539 | int register_ftrace_direct(struct ftrace_ops *ops, unsigned long ip, unsigned long addr);
         |     ^~~~~~~~~~~~~~~~~~~~~~
   samples/ftrace/ftrace-direct-multi.c: In function 'ftrace_direct_multi_exit':
>> samples/ftrace/ftrace-direct-multi.c:233:9: error: too few arguments to function 'unregister_ftrace_direct'
     233 |         unregister_ftrace_direct(&direct, (unsigned long) my_tramp, true);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/ftrace.h:540:5: note: declared here
     540 | int unregister_ftrace_direct(struct ftrace_ops *ops, unsigned long ip, unsigned long addr,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~
   samples/ftrace/ftrace-direct-multi.c: In function 'ftrace_direct_multi_init':
>> samples/ftrace/ftrace-direct-multi.c:229:1: warning: control reaches end of non-void function [-Wreturn-type]
     229 | }
         | ^
--
   samples/ftrace/ftrace-direct-multi-modify.c: In function 'simple_thread':
>> samples/ftrace/ftrace-direct-multi-modify.c:347:23: error: too few arguments to function 'modify_ftrace_direct'
     347 |                 ret = modify_ftrace_direct(&direct, tramps[t]);
         |                       ^~~~~~~~~~~~~~~~~~~~
   In file included from samples/ftrace/ftrace-direct-multi-modify.c:4:
   include/linux/ftrace.h:542:5: note: declared here
     542 | int modify_ftrace_direct(struct ftrace_ops *ops, unsigned long ip, unsigned long addr, bool lock_direct_mutex);
         |     ^~~~~~~~~~~~~~~~~~~~
   samples/ftrace/ftrace-direct-multi-modify.c: In function 'ftrace_direct_multi_init':
>> samples/ftrace/ftrace-direct-multi-modify.c:365:15: error: too few arguments to function 'register_ftrace_direct'
     365 |         ret = register_ftrace_direct(&direct, my_tramp);
         |               ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/ftrace.h:539:5: note: declared here
     539 | int register_ftrace_direct(struct ftrace_ops *ops, unsigned long ip, unsigned long addr);
         |     ^~~~~~~~~~~~~~~~~~~~~~
   samples/ftrace/ftrace-direct-multi-modify.c: In function 'ftrace_direct_multi_exit':
>> samples/ftrace/ftrace-direct-multi-modify.c:375:9: error: too few arguments to function 'unregister_ftrace_direct'
     375 |         unregister_ftrace_direct(&direct, my_tramp, true);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/ftrace.h:540:5: note: declared here
     540 | int unregister_ftrace_direct(struct ftrace_ops *ops, unsigned long ip, unsigned long addr,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~


vim +/register_ftrace_direct +228 samples/ftrace/ftrace-direct-multi.c

5fae941b9a6f95 Jiri Olsa      2021-10-08  222  
5fae941b9a6f95 Jiri Olsa      2021-10-08  223  static int __init ftrace_direct_multi_init(void)
5fae941b9a6f95 Jiri Olsa      2021-10-08  224  {
5fae941b9a6f95 Jiri Olsa      2021-10-08  225  	ftrace_set_filter_ip(&direct, (unsigned long) wake_up_process, 0, 0);
5fae941b9a6f95 Jiri Olsa      2021-10-08  226  	ftrace_set_filter_ip(&direct, (unsigned long) schedule, 0, 0);
5fae941b9a6f95 Jiri Olsa      2021-10-08  227  
da8bdfbd422333 Florent Revest 2023-03-21 @228  	return register_ftrace_direct(&direct, (unsigned long) my_tramp);
5fae941b9a6f95 Jiri Olsa      2021-10-08 @229  }
5fae941b9a6f95 Jiri Olsa      2021-10-08  230  
5fae941b9a6f95 Jiri Olsa      2021-10-08  231  static void __exit ftrace_direct_multi_exit(void)
5fae941b9a6f95 Jiri Olsa      2021-10-08  232  {
da8bdfbd422333 Florent Revest 2023-03-21 @233  	unregister_ftrace_direct(&direct, (unsigned long) my_tramp, true);
5fae941b9a6f95 Jiri Olsa      2021-10-08  234  }
5fae941b9a6f95 Jiri Olsa      2021-10-08  235  

:::::: The code at line 228 was first introduced by commit
:::::: da8bdfbd422333fbb7c85ac1d7f18592d17d6665 ftrace: Rename _ftrace_direct_multi APIs to _ftrace_direct APIs

:::::: TO: Florent Revest <revest@chromium.org>
:::::: CC: Steven Rostedt (Google) <rostedt@goodmis.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki