Re: [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]

On Fri, Oct 24, 2025 at 11:12:07AM +0100, Jonathan Cameron wrote:
> On Thu, 23 Oct 2025 19:24:17 +0100
> Conor Dooley <conor@kernel.org> wrote:
> 
> > On Thu, Oct 23, 2025 at 02:01:37PM +0300, Nuno Sá wrote:
> > > Add device tree binding documentation for the Analog Devices AD5446
> > > family of Digital-to-Analog Converters and compatible devices from
> > > Texas Instruments. There's both SPI and I2C interfaces and feature
> > > resolutions ranging from 8-bit to 16-bit.
> > > 
> > > The binding covers 29 compatible devices including the AD5446 series,  
> > 
> > If they're compatible, how come there's no fallback use? Just to keep
> > things consistent with how they've always been while probing as spi
> > child devices?
> Hi Conor,
> 
> They aren't compatible. The 2nd patch is misleading because it doesn't
> associate data with the of_device_id.  The driver is getting that from
> matching the compatible property with manufacturer stripped off.
> 
> I've requested Nuno sort that out in v3. It's a bit more than just
> adding the data as would also involve moving away from using an enum
> to using pointers to the structures that the enum indexes (currently in
> an array).
> 
> https://elixir.bootlin.com/linux/v6.17.4/source/drivers/iio/dac/ad5446.c#L315
> 

Right, I think the wording about "compatible" should be removed from the
commit message here then. Maybe something like "derivative devices"
would be a better fit?

pw-bot: changes-requested

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]