All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Wilfred Mallawa <wilfred.opensource@gmail.com>
Cc: Sabrina Dubroca <sd@queasysnail.net>,
	netdev@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Jonathan Corbet	 <corbet@lwn.net>,
	Simon Horman <horms@kernel.org>,
	John Fastabend	 <john.fastabend@gmail.com>,
	Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH net-next v8 1/2] net/tls: support setting the maximum payload size
Date: Fri, 24 Oct 2025 16:33:36 -0700	[thread overview]
Message-ID: <20251024163336.5fba5cd1@kernel.org> (raw)
In-Reply-To: <cd557c5b11b04da060f07d3849dc46e7b3625ed1.camel@gmail.com>

On Fri, 24 Oct 2025 12:11:11 +1000 Wilfred Mallawa wrote:
> In the previous record_size_limit approach for TLS 1.3, we need to
> account for the ContentType byte. Which complicates get/setsockopt()
> and tls_get_info(), where in setsockopt() for TLS 1.3 we need to
> subtract 1 to the user provided value and in getsockopt() we need add 1
> to keep the symmetry between the two (similarly in tls_get_info()). The
> underlying assumption was that userspace passes up directly what the
> endpoint specified as the record_size_limit.
> 
> With this approach we don't need to worry about it and we can pass the
> responsibility to user-space as documented, which I think makes the
> kernel code simpler.

But we haven't managed to avoid that completely:

+	if (value < TLS_MIN_RECORD_SIZE_LIM - (tls_13 ? 1 : 0) ||

I understand the motivation, the kernel code is indeed simpler.

Last night I read the RFC and then this patch, and it took me like
10min to get all of it straight in my head. Maybe I was tried but
I feel like the user space developers will judge us harshly for 
the current uAPI.

  reply	other threads:[~2025-10-24 23:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22  0:19 [PATCH net-next v8 1/2] net/tls: support setting the maximum payload size Wilfred Mallawa
2025-10-22  0:19 ` [PATCH net-next v8 2/2] selftests: tls: add tls record_size_limit test Wilfred Mallawa
2025-10-22 21:51   ` Sabrina Dubroca
2025-10-22 21:51 ` [PATCH net-next v8 1/2] net/tls: support setting the maximum payload size Sabrina Dubroca
2025-10-24  1:44 ` Jakub Kicinski
2025-10-24  2:11   ` Wilfred Mallawa
2025-10-24 23:33     ` Jakub Kicinski [this message]
2025-10-26  8:50       ` Wilfred Mallawa
2025-10-27 11:32       ` Sabrina Dubroca
2025-10-27 23:13         ` Jakub Kicinski
2025-10-27 23:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251024163336.5fba5cd1@kernel.org \
    --to=kuba@kernel.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sd@queasysnail.net \
    --cc=shuah@kernel.org \
    --cc=wilfred.opensource@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.