From: Jakub Kicinski <kuba@kernel.org>
To: Yonglong Li <liyonglong@chinatelecom.cn>
Cc: netdev@vger.kernel.org, davem@davemloft.net, dsahern@kernel.org,
edumazet@google.com, pabeni@redhat.com, horms@kernel.org
Subject: Re: [PATCH net v2 1/2] net: ip: add drop reasons when handling ip fragments
Date: Fri, 24 Oct 2025 17:24:49 -0700 [thread overview]
Message-ID: <20251024172449.59d14f9f@kernel.org> (raw)
In-Reply-To: <1761301212-34487-2-git-send-email-liyonglong@chinatelecom.cn>
On Fri, 24 Oct 2025 18:20:11 +0800 Yonglong Li wrote:
> Subject: [PATCH net v2 1/2] net: ip: add drop reasons when handling ip fragments
net-next, please read the whole doc Eric linked
> 1, add new drop reason FRAG_FAILED/FRAG_OUTPUT_FAILED
> 2, use drop reasons in ip_fragment
Personally IDK if this is sufficiently semantically significant
to warrant merging. FRAG_FAILED means "unidentified error during
fragmentation"? ip_frag_next() only returns -ENOMEM and
SKB_DROP_REASON_NOMEM already exists, so just use that.
FRAG_OUTPUT_FAILED means something failed in output so it'd be more
meaningful to figure out what failed there, instead of adding
a bunch of ${CALLER}_OUTPUT_FAILED
next prev parent reply other threads:[~2025-10-25 0:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 10:20 [PATCH net v2 0/2] add drop reason when do fragment Yonglong Li
2025-10-24 10:20 ` [PATCH net v2 1/2] net: ip: add drop reasons when handling ip fragments Yonglong Li
2025-10-25 0:24 ` Jakub Kicinski [this message]
2025-10-24 10:20 ` [PATCH net v2 2/2] net: ipv6: use drop reasons in ip6_fragment Yonglong Li
2025-10-24 11:25 ` [PATCH net v2 0/2] add drop reason when do fragment Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2025-10-27 2:32 Yonglong Li
2025-10-27 2:32 ` [PATCH net v2 1/2] net: ip: add drop reasons when handling ip fragments Yonglong Li
2025-10-28 7:34 ` YonglongLi
2025-10-29 0:05 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251024172449.59d14f9f@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=liyonglong@chinatelecom.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.