From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66B96221555; Fri, 24 Oct 2025 17:47:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761328079; cv=none; b=oTj4/Y3SsnXQ+hQo4F6kkY3JEazESJ57p2Q/FTFzk0d0/361n+lDUMnZ0p3TULa/MhL0EKWbn+8bfnmi7AJemqaMOWzAPpGZa15B/7nB6Kqb3g7vpNPB0ZeDmQURn0EoZ9dZbYIKUC/1dxxwq0zAovCwR1JI9JIcOaDH4obBuqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761328079; c=relaxed/simple; bh=UfbLZEdW6c5fIJ4gmYTVH2hQEMNye441ija506nCvs4=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VMOfQr+Dxtk+z0EC08JyeVJRmxzUY5HWKZnf/105ZXtjyDGdQcegaVfxu8WiCW+jYEAspK+wjTFpUJo7GVSrnSXs9YmMIQHpKCXzMA68PkF3OFaelVs8UnrBbs0Yd+VtnqL7HLHSp6i2LZfesFRje/DWcotqsR/4exOTkfZLeeE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ctVdR3hSQz6M4f9; Sat, 25 Oct 2025 01:44:11 +0800 (CST) Received: from dubpeml100005.china.huawei.com (unknown [7.214.146.113]) by mail.maildlp.com (Postfix) with ESMTPS id DCB5F1402ED; Sat, 25 Oct 2025 01:47:54 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml100005.china.huawei.com (7.214.146.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 24 Oct 2025 18:47:53 +0100 Date: Fri, 24 Oct 2025 18:47:51 +0100 From: Jonathan Cameron To: James Morse CC: , , , D Scott Phillips OS , , , , , , Jamie Iles , Xin Hao , , , , David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , , , Rob Herring , Rohit Mathew , "Rafael Wysocki" , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , "Will Deacon" , Greg Kroah-Hartman , Danilo Krummrich , Jeremy Linton , Gavin Shan Subject: Re: [PATCH v3 13/29] arm_mpam: Probe the hardware features resctrl supports Message-ID: <20251024184751.00003a81@huawei.com> In-Reply-To: <20251017185645.26604-14-james.morse@arm.com> References: <20251017185645.26604-1-james.morse@arm.com> <20251017185645.26604-14-james.morse@arm.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500009.china.huawei.com (7.191.174.84) To dubpeml100005.china.huawei.com (7.214.146.113) On Fri, 17 Oct 2025 18:56:29 +0000 James Morse wrote: > Expand the probing support with the control and monitor types > we can use with resctrl. > > CC: Dave Martin > Signed-off-by: James Morse > Reviewed-by: Jonathan Cameron > Reviewed-by: Fenghua Yu > Tested-by: Fenghua Yu Trivial thing inline. LGTM. > diff --git a/drivers/resctrl/mpam_internal.h b/drivers/resctrl/mpam_internal.h > index 1afc52b36328..be9ea0aab6d2 100644 > --- a/drivers/resctrl/mpam_internal.h > +++ b/drivers/resctrl/mpam_internal.h > @@ -5,6 +5,7 @@ > #define MPAM_INTERNAL_H > > #include > +#include > #include > #include > #include > @@ -13,6 +14,7 @@ > #include > #include > #include > +#include > > #define MPAM_MSC_MAX_NUM_RIS 16 > > @@ -111,6 +113,33 @@ static inline void mpam_mon_sel_lock_init(struct mpam_msc *msc) > raw_spin_lock_init(&msc->_mon_sel_lock); > } > > +/* Bits for mpam features bitmaps */ > +enum mpam_device_features { > + mpam_feat_cpor_part = 0, Given you are using this for internal stuff and the numbers don't mean anything explicit I think you can drop the = 0. > + mpam_feat_mbw_part, > + mpam_feat_mbw_min, > + mpam_feat_mbw_max, > + mpam_feat_msmon, > + mpam_feat_msmon_csu, > + mpam_feat_msmon_csu_hw_nrdy, > + mpam_feat_msmon_mbwu, > + mpam_feat_msmon_mbwu_hw_nrdy, > + MPAM_FEATURE_LAST > +};