From: Eric Biggers <ebiggers@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH v1 1/1] sched: Remove never used code in mm_cid_get()
Date: Fri, 24 Oct 2025 14:19:01 -0700 [thread overview]
Message-ID: <20251024211901.GC2068@quark> (raw)
In-Reply-To: <20251020104934.GQ3419281@noisy.programming.kicks-ass.net>
On Mon, Oct 20, 2025 at 12:49:34PM +0200, Peter Zijlstra wrote:
> On Mon, Oct 20, 2025 at 01:10:44PM +0300, Andy Shevchenko wrote:
> > On Wed, Oct 15, 2025 at 11:19:34AM +0200, Andy Shevchenko wrote:
> > > Clang is not happy with set but unused variable (this is visible
> > > with `make W=1` build:
> > >
> > > kernel/sched/sched.h:3744:18: error: variable 'cpumask' set but not used [-Werror,-Wunused-but-set-variable]
> > >
> > > It seems like the variable was never be used along with the assignment that
> > > does not have side effects as far as I can see. Remove those altogether.
> >
> > Anybody to apply this for fixes?
>
> Why? W=1 and WERROR is very much you get to keep the pieces land, no?
Tested-by: Eric Biggers <ebiggers@kernel.org>
Linus, could you consider applying this directly? This seems to have
broken W=1 for basically the whole kernel. I see many other people
already ran into this and sent the same patch
(https://lore.kernel.org/r/20251002-sched-w1-v1-1-a6fdf549d179@linaro.org
https://lore.kernel.org/r/20251009194818.1587650-1-kriish.sharma2006@gmail.com
https://lore.kernel.org/r/20251017073050.2411988-1-kevin.brodsky@arm.com
https://lore.kernel.org/r/20251020220601.176639-1-adigollamudi@gmail.com)
but unfortunately the maintainer is refusing to apply any of them.
I find W=1 to be useful, and I keep my subsystems W=1 clean. But I
cannot do that if W=1 is broken for all kernel builds.
I think it's clear that a lot of other people find it useful too.
- Eric
next prev parent reply other threads:[~2025-10-24 21:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 9:19 [PATCH v1 1/1] sched: Remove never used code in mm_cid_get() Andy Shevchenko
2025-10-20 10:10 ` Andy Shevchenko
2025-10-20 10:49 ` Peter Zijlstra
2025-10-22 16:46 ` Andy Shevchenko
2025-10-24 21:19 ` Eric Biggers [this message]
2025-10-24 23:56 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251024211901.GC2068@quark \
--to=ebiggers@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.