All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Alex Markuze <amarkuze@redhat.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC PATCH 5/5] ceph: Activate BLOG logging
Date: Sat, 25 Oct 2025 13:08:53 +0800	[thread overview]
Message-ID: <202510251256.eh8qnDln-lkp@intel.com> (raw)
In-Reply-To: <20251024084259.2359693-6-amarkuze@redhat.com>

Hi Alex,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-nonmm-unstable]
[also build test ERROR on tip/sched/core linus/master v6.18-rc2 next-20251024]
[cannot apply to ceph-client/testing ceph-client/for-linus]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alex-Markuze/sched-fork-Wire-BLOG-contexts-into-task-lifecycle/20251024-164832
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable
patch link:    https://lore.kernel.org/r/20251024084259.2359693-6-amarkuze%40redhat.com
patch subject: [RFC PATCH 5/5] ceph: Activate BLOG logging
config: xtensa-randconfig-002-20251025 (https://download.01.org/0day-ci/archive/20251025/202510251256.eh8qnDln-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 14.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251025/202510251256.eh8qnDln-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510251256.eh8qnDln-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/ceph/file.c: In function 'ceph_splice_read':
>> fs/ceph/file.c:2268:9: error: implicit declaration of function 'bout'; did you mean 'dout'? [-Wimplicit-function-declaration]
    2268 |         bout("splice_read %p %llx.%llx %llu~%zu trying to get caps on %p\n",
         |         ^~~~
         |         dout
--
   fs/ceph/super.c: In function 'ceph_parse_new_source':
>> fs/ceph/super.c:280:17: error: implicit declaration of function 'bout'; did you mean 'dout'? [-Wimplicit-function-declaration]
     280 |                 bout("separator '=' missing in source");
         |                 ^~~~
         |                 dout


vim +2268 fs/ceph/file.c

  2251	
  2252	/*
  2253	 * Wrap filemap_splice_read with checks for cap bits on the inode.
  2254	 * Atomically grab references, so that those bits are not released
  2255	 * back to the MDS mid-read.
  2256	 */
  2257	static ssize_t ceph_splice_read(struct file *in, loff_t *ppos,
  2258					struct pipe_inode_info *pipe,
  2259					size_t len, unsigned int flags)
  2260	{
  2261		struct ceph_file_info *fi = in->private_data;
  2262		struct inode *inode = file_inode(in);
  2263		struct ceph_inode_info *ci = ceph_inode(inode);
  2264		ssize_t ret;
  2265		int want = 0, got = 0;
  2266		CEPH_DEFINE_RW_CONTEXT(rw_ctx, 0);
  2267	
> 2268		bout("splice_read %p %llx.%llx %llu~%zu trying to get caps on %p\n",
  2269		     inode, ceph_vinop(inode), *ppos, len, inode);
  2270	
  2271		if (ceph_inode_is_shutdown(inode))
  2272			return -ESTALE;
  2273	
  2274		if (ceph_has_inline_data(ci) ||
  2275		    (fi->flags & CEPH_F_SYNC))
  2276			return copy_splice_read(in, ppos, pipe, len, flags);
  2277	
  2278		ret = ceph_start_io_read(inode);
  2279		if (ret)
  2280			return ret;
  2281	
  2282		want = CEPH_CAP_FILE_CACHE;
  2283		if (fi->fmode & CEPH_FILE_MODE_LAZY)
  2284			want |= CEPH_CAP_FILE_LAZYIO;
  2285	
  2286		ret = ceph_get_caps(in, CEPH_CAP_FILE_RD, want, -1, &got);
  2287		if (ret < 0)
  2288			goto out_end;
  2289	
  2290		if ((got & (CEPH_CAP_FILE_CACHE | CEPH_CAP_FILE_LAZYIO)) == 0) {
  2291			bout("splice_read/sync %p %llx.%llx %llu~%zu got cap refs on %s\n",
  2292			     inode, ceph_vinop(inode), *ppos, len,
  2293			     ceph_cap_string(got));
  2294	
  2295			ceph_put_cap_refs(ci, got);
  2296			ceph_end_io_read(inode);
  2297			return copy_splice_read(in, ppos, pipe, len, flags);
  2298		}
  2299	
  2300		bout("splice_read %p %llx.%llx %llu~%zu got cap refs on %s\n",
  2301		     inode, ceph_vinop(inode), *ppos, len, ceph_cap_string(got));
  2302	
  2303		rw_ctx.caps = got;
  2304		ceph_add_rw_context(fi, &rw_ctx);
  2305		ret = filemap_splice_read(in, ppos, pipe, len, flags);
  2306		ceph_del_rw_context(fi, &rw_ctx);
  2307	
  2308		bout("splice_read %p %llx.%llx dropping cap refs on %s = %zd\n",
  2309		     inode, ceph_vinop(inode), ceph_cap_string(got), ret);
  2310	
  2311		ceph_put_cap_refs(ci, got);
  2312	out_end:
  2313		ceph_end_io_read(inode);
  2314		return ret;
  2315	}
  2316	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2025-10-25  5:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-24  8:42 [RFC PATCH 0/5] BLOG: per-task logging contexts with Ceph consumer Alex Markuze
2025-10-24  8:42 ` [RFC PATCH 1/5] sched, fork: Wire BLOG contexts into task lifecycle Alex Markuze
2025-10-24 17:44   ` Steven Rostedt
2025-10-29 18:57   ` Viacheslav Dubeyko
2025-10-24  8:42 ` [RFC PATCH 2/5] lib: Introduce BLOG (Binary LOGging) subsystem Alex Markuze
2025-10-30 18:47   ` Viacheslav Dubeyko
2025-10-24  8:42 ` [RFC PATCH 3/5] ceph: Add BLOG scaffolding Alex Markuze
2025-11-03 22:37   ` Viacheslav Dubeyko
2025-10-24  8:42 ` [RFC PATCH 4/5] ceph: Add BLOG debugfs support Alex Markuze
2025-10-25  3:56   ` kernel test robot
2025-10-25  7:14   ` kernel test robot
2025-11-03 21:07   ` Viacheslav Dubeyko
2025-10-24  8:42 ` [RFC PATCH 5/5] ceph: Activate BLOG logging Alex Markuze
2025-10-25  5:08   ` kernel test robot [this message]
2025-11-03 21:00   ` Viacheslav Dubeyko
2025-10-24 15:32 ` [RFC PATCH 0/5] BLOG: per-task logging contexts with Ceph consumer David Hildenbrand
2025-10-24 17:53 ` Steven Rostedt
2025-10-25 10:50   ` Alex Markuze
2025-10-25 14:59     ` Steven Rostedt
2025-10-25 17:54       ` Alex Markuze
2025-10-27 14:54         ` Steven Rostedt
2025-10-28 17:07 ` Viacheslav Dubeyko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202510251256.eh8qnDln-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=amarkuze@redhat.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.