From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E1E8CCD193 for ; Sun, 26 Oct 2025 08:13:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E7A3710E044; Sun, 26 Oct 2025 08:13:19 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="RE6XywIx"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E28710E044 for ; Sun, 26 Oct 2025 08:13:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1761466397; bh=od6ChUUR+8/ACM0Q9cUVA9gbg9IV6GRMIjrKhyw5AEU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RE6XywIxAuMfSxG2mdTNpFGV7lCjjogAjgW/ix07HTwa0yNzBAIkKCcpJNJDui3zr lZIt53PM35whuJSlW+PJ93j5sqGESA9+8H/S97Fs5sErzRkmGzVLi97Gt3VZf1PBLz LPGAw7pxkNUJWcY7uYb4ZlosjcHhhViwJLjqxtSvRi/eshzghMSw+HQi3ww+Rsm0nw fvNsSbk/xdje8+y2YTfwP+EnguDXdCzYVH1y0LgbF59HAtZ4oIZ+E20MpQBiilBh7v E7oToM/7EgQ9qHdi/pl4potkuXC8rYP5qhnWVqrRlNhCfI+EtCD3OEpZN5aMZ9rQYf awzAu1o5Vfopw== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 8473617E126B; Sun, 26 Oct 2025 09:13:16 +0100 (CET) Date: Sun, 26 Oct 2025 09:13:10 +0100 From: Boris Brezillon To: Karunika Choo Cc: dri-devel@lists.freedesktop.org, nd@arm.com, Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/8] drm/panthor: Introduce panthor_pwr API and power control framework Message-ID: <20251026091310.4046f061@fedora> In-Reply-To: <20251024202117.3241292-4-karunika.choo@arm.com> References: <20251024202117.3241292-1-karunika.choo@arm.com> <20251024202117.3241292-4-karunika.choo@arm.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 24 Oct 2025 21:21:12 +0100 Karunika Choo wrote: > diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/panthor/panthor_hw.c > index 092962db5ccd..09aef34a6ce7 100644 > --- a/drivers/gpu/drm/panthor/panthor_hw.c > +++ b/drivers/gpu/drm/panthor/panthor_hw.c > @@ -192,3 +192,8 @@ int panthor_hw_init(struct panthor_device *ptdev) > > return 0; > } > + > +bool panthor_hw_has_pwr_ctrl(struct panthor_device *ptdev) > +{ > + return GPU_ARCH_MAJOR(ptdev->gpu_info.gpu_id) >= 14; > +} > diff --git a/drivers/gpu/drm/panthor/panthor_hw.h b/drivers/gpu/drm/panthor/panthor_hw.h > index 2665d6dde2e3..4c71f27d1c0b 100644 > --- a/drivers/gpu/drm/panthor/panthor_hw.h > +++ b/drivers/gpu/drm/panthor/panthor_hw.h > @@ -32,4 +32,6 @@ struct panthor_hw { > > int panthor_hw_init(struct panthor_device *ptdev); > > +bool panthor_hw_has_pwr_ctrl(struct panthor_device *ptdev); Let's make this a static inline function so the compiler can inline its content at compile time.