From: Christoph Hellwig <hch@lst.de>
To: Leon Romanovsky <leon@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2 1/2] nvme-pci: migrate to dma_map_phys instead of map_page
Date: Mon, 27 Oct 2025 07:49:26 +0100 [thread overview]
Message-ID: <20251027064926.GA13214@lst.de> (raw)
In-Reply-To: <20251026123804.GD12554@unreal>
On Sun, Oct 26, 2025 at 02:38:04PM +0200, Leon Romanovsky wrote:
> On Wed, Oct 22, 2025 at 08:14:18AM +0200, Christoph Hellwig wrote:
> > This actually has block and nvme bits, so the subject line should
> > say that.
> >
> > > + unsigned int attrs = 0;
> >
> > attrs is always zero here, no need to start passing it for the
> > map_phys conversion alone.
> >
> > > + unsigned int attrs = 0;
> >
> > Same here.
>
> It gave me more clean second patch where I only added new attribute, but
> if it doesn't look right to you, let's change.
The usual rule is do one thing at a time. There might be an occasinal
slight bend of the rule to make life easier, but I don't think that
really fits here.
next prev parent reply other threads:[~2025-10-27 6:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 17:00 [PATCH v2 0/2] block: Enable proper MMIO memory handling for P2P DMA Leon Romanovsky
2025-10-20 17:00 ` [PATCH v2 1/2] nvme-pci: migrate to dma_map_phys instead of map_page Leon Romanovsky
2025-10-20 23:36 ` Chaitanya Kulkarni
2025-10-22 6:14 ` Christoph Hellwig
2025-10-26 12:38 ` Leon Romanovsky
2025-10-27 6:49 ` Christoph Hellwig [this message]
2025-10-20 17:00 ` [PATCH v2 2/2] block-dma: properly take MMIO path Leon Romanovsky
2025-10-20 23:37 ` Chaitanya Kulkarni
2025-10-22 6:21 ` Christoph Hellwig
2025-10-26 13:30 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027064926.GA13214@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=leon@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.