From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>,
Vinod Koul <vkoul@kernel.org>, Sinan Kaya <okaya@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Michal Simek <michal.simek@amd.com>,
Stephan Gerhold <stephan.gerhold@linaro.org>,
Md Sadre Alam <quic_mdalam@quicinc.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Casey Connolly <casey.connolly@linaro.org>,
Abin Joseph <abin.joseph@amd.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
linux-arm-msm@vger.kernel.org
Subject: [PATCH 4/6] dmaengine: ste_dma40: Remove redundant pm_runtime_mark_last_busy() calls
Date: Mon, 27 Oct 2025 15:32:30 +0200 [thread overview]
Message-ID: <20251027133232.392898-4-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20251027133232.392898-1-sakari.ailus@linux.intel.com>
pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
pm_runtime_mark_last_busy().
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/dma/ste_dma40.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index d52e1685aed5..e67e0d66e6e8 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -1452,7 +1452,6 @@ static int d40_pause(struct dma_chan *chan)
res = d40_channel_execute_command(d40c, D40_DMA_SUSPEND_REQ);
- pm_runtime_mark_last_busy(d40c->base->dev);
pm_runtime_put_autosuspend(d40c->base->dev);
spin_unlock_irqrestore(&d40c->lock, flags);
return res;
@@ -1479,7 +1478,6 @@ static int d40_resume(struct dma_chan *chan)
if (d40_residue(d40c) || d40_tx_is_linked(d40c))
res = d40_channel_execute_command(d40c, D40_DMA_RUN);
- pm_runtime_mark_last_busy(d40c->base->dev);
pm_runtime_put_autosuspend(d40c->base->dev);
spin_unlock_irqrestore(&d40c->lock, flags);
return res;
@@ -1581,7 +1579,6 @@ static void dma_tc_handle(struct d40_chan *d40c)
if (d40_queue_start(d40c) == NULL) {
d40c->busy = false;
- pm_runtime_mark_last_busy(d40c->base->dev);
pm_runtime_put_autosuspend(d40c->base->dev);
}
@@ -2054,16 +2051,13 @@ static int d40_free_dma(struct d40_chan *d40c)
else
d40c->base->lookup_phy_chans[phy->num] = NULL;
- if (d40c->busy) {
- pm_runtime_mark_last_busy(d40c->base->dev);
+ if (d40c->busy)
pm_runtime_put_autosuspend(d40c->base->dev);
- }
d40c->busy = false;
d40c->phy_chan = NULL;
d40c->configured = false;
mark_last_busy:
- pm_runtime_mark_last_busy(d40c->base->dev);
pm_runtime_put_autosuspend(d40c->base->dev);
return res;
}
@@ -2466,7 +2460,6 @@ static int d40_alloc_chan_resources(struct dma_chan *chan)
if (is_free_phy)
d40_config_write(d40c);
mark_last_busy:
- pm_runtime_mark_last_busy(d40c->base->dev);
pm_runtime_put_autosuspend(d40c->base->dev);
spin_unlock_irqrestore(&d40c->lock, flags);
return err;
@@ -2618,12 +2611,9 @@ static int d40_terminate_all(struct dma_chan *chan)
chan_err(d40c, "Failed to stop channel\n");
d40_term_all(d40c);
- pm_runtime_mark_last_busy(d40c->base->dev);
pm_runtime_put_autosuspend(d40c->base->dev);
- if (d40c->busy) {
- pm_runtime_mark_last_busy(d40c->base->dev);
+ if (d40c->busy)
pm_runtime_put_autosuspend(d40c->base->dev);
- }
d40c->busy = false;
spin_unlock_irqrestore(&d40c->lock, flags);
--
2.47.3
next prev parent reply other threads:[~2025-10-27 13:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 13:32 [PATCH 1/6] dmaengine: at_xdmac: Remove redundant pm_runtime_mark_last_busy() calls Sakari Ailus
2025-10-27 13:32 ` [PATCH 2/6] dmaengine: pl330: " Sakari Ailus
2025-10-27 13:32 ` [PATCH 3/6] dmaengine: qcom: " Sakari Ailus
2025-10-27 13:36 ` Dmitry Baryshkov
2025-12-16 16:53 ` Vinod Koul
2025-10-27 13:32 ` Sakari Ailus [this message]
2025-10-29 14:16 ` [PATCH 4/6] dmaengine: ste_dma40: " Linus Walleij
2025-10-27 13:32 ` [PATCH 5/6] dmaengine: ti: " Sakari Ailus
2025-10-27 13:32 ` [PATCH 6/6] dmaengine: zynqmp_dma: " Sakari Ailus
2025-10-31 6:55 ` Joseph, Abin
2025-12-16 16:59 ` [PATCH 1/6] dmaengine: at_xdmac: " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027133232.392898-4-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=abin.joseph@amd.com \
--cc=casey.connolly@linaro.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=michal.simek@amd.com \
--cc=okaya@kernel.org \
--cc=quic_mdalam@quicinc.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=stephan.gerhold@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.