From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6931830FC0F; Mon, 27 Oct 2025 18:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590452; cv=none; b=kr5WZQfq9tlZdnispzJ1Kjp5nfWumeBh0oUxYHH9xbJ+a0jveT4FwrJnaAwyj15sHlij89dscT90w/0LxpfCoH2dWLd0+ykkxI/xdakn5KCKEsGOxK1Dopmsj9rHj2eO9Wc6zSBalSk0G1HHk2+UOeIA7X0va7AGnnKyM9ckIOg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590452; c=relaxed/simple; bh=drOSVOMf1guSJRzcdbg4uiw9N3UaJBFLqzy4/0ZP9bc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i9YydJdhDrRpvgvJGPR8stQSMYC9ZzgvOOLJAtEVBjIAiL1MEytaE3LI6cBDx1rW6f3gCEzULyqYFhcN4xBXL9hYXm/JiFx37p3SbhHkcKjPhd4pW2fpZqHIA6aIg+hBLEwotfdy2s4L4qfZqI/g6v8aMHRIncxx1aZ1UdGF/os= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=y1GNaPfB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="y1GNaPfB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8515C4CEF1; Mon, 27 Oct 2025 18:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761590452; bh=drOSVOMf1guSJRzcdbg4uiw9N3UaJBFLqzy4/0ZP9bc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y1GNaPfBAZjUUdZjm+IlQIickditgLNazsRnPlWVNdYRkR5MHmea4IHvpaSmDI1lo VzE9qDR/zfK+K0Jgh/zoyf2BCJohzHRQqiUnAoG5ep7FQXadl9htTU8sum5YwPRf/I sChaL02COceDUAn97Nuxolic4a6k+edvkIfUGMlo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Donet Tom , David Hildenbrand , Alison Schofield , Danilo Krummrich , Dave Jiang , Hiroyouki Kamezawa , Joanthan Cameron , Oscar Salvador , "Ritesh Harjani (IBM)" , "Yury Norov (NVIDIA)" , Zi Yan , Andrew Morton , Sasha Levin Subject: [PATCH 5.4 051/224] drivers/base/node: handle error properly in register_one_node() Date: Mon, 27 Oct 2025 19:33:17 +0100 Message-ID: <20251027183510.365085425@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183508.963233542@linuxfoundation.org> References: <20251027183508.963233542@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Donet Tom [ Upstream commit 786eb990cfb78aab94eb74fb32a030e14723a620 ] If register_node() returns an error, it is not handled correctly. The function will proceed further and try to register CPUs under the node, which is not correct. So, in this patch, if register_node() returns an error, we return immediately from the function. Link: https://lkml.kernel.org/r/20250822084845.19219-1-donettom@linux.ibm.com Fixes: 76b67ed9dce6 ("[PATCH] node hotplug: register cpu: remove node struct") Signed-off-by: Donet Tom Acked-by: David Hildenbrand Cc: Alison Schofield Cc: Danilo Krummrich Cc: Dave Jiang Cc: Donet Tom Cc: Greg Kroah-Hartman Cc: Hiroyouki Kamezawa Cc: Joanthan Cameron Cc: Oscar Salvador Cc: "Ritesh Harjani (IBM)" Cc: Yury Norov (NVIDIA) Cc: Zi Yan Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- drivers/base/node.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/base/node.c b/drivers/base/node.c index 666eb55c0774e..cb1bbe3068ab6 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -938,6 +938,11 @@ int __register_one_node(int nid) return -ENOMEM; error = register_node(node_devices[nid], nid); + if (error) { + node_devices[nid] = NULL; + kfree(node); + return error; + } /* link cpu under this node */ for_each_present_cpu(cpu) { -- 2.51.0