From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C7BF313520; Mon, 27 Oct 2025 18:40:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590455; cv=none; b=htXrk/6fJFpTkD3lyHIXZbBY/rciML+a02ySI5+zOaToZWzrVbpMDWymN5jPZeRs47jQ6Lr+r7K1BXyCz4VRGqiGECEDk8ACO3mAFOrsLLN9F1BbUnhGq+lxFgJnCFdLQN20fAw8Zjc689AfFzEynlY/Et9dMg7X4OsZuLOF4K8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590455; c=relaxed/simple; bh=QmkPtarn0F+Gih5qvOpNLWnb7emNTLNhT5ra1jAqSxY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J+l0yjGayAwGP8pbTY+jRKeYG5yn1Q4HaSrJwdnDnwXIkZ1/stxFOd7T2K9j8DBWikGsqbR+gAXCOUwRGPomMx0mYjW1qgADnR6UrbJTaLIOiDGkb+tPIh68bTOSC6fILMYY7m6ZTsEREVt3fC9CsS3WjZxlbAmhFRooMeXjHAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XgZodrev; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XgZodrev" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E019C4CEF1; Mon, 27 Oct 2025 18:40:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761590454; bh=QmkPtarn0F+Gih5qvOpNLWnb7emNTLNhT5ra1jAqSxY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XgZodrev7uYC7ZGx3K07vtLn3x6AVdiPouRJncsWdfX54rf5xV5tO9003Fsrl0Udh /li5KPqlX4QnS81UMu9hSqnabNqQKKGECmqne2lDJYDSiuvAYnjMunCXdxhrRQk/FF Tmi4yAXWmXwYLnyYwjQmteEqtLipPNuBQBIwdyIU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Abdun Nihaal , Jiri Slaby , Felix Fietkau , Sasha Levin Subject: [PATCH 5.4 052/224] wifi: mt76: fix potential memory leak in mt76_wmac_probe() Date: Mon, 27 Oct 2025 19:33:18 +0100 Message-ID: <20251027183510.392938454@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183508.963233542@linuxfoundation.org> References: <20251027183508.963233542@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Abdun Nihaal [ Upstream commit 42754b7de2b1a2cf116c5e3f1e8e78392f4ed700 ] In mt76_wmac_probe(), when the mt76_alloc_device() call succeeds, memory is allocated for both struct ieee80211_hw and a workqueue. However, on the error path, the workqueue is not freed. Fix that by calling mt76_free_device() on the error path. Fixes: c8846e101502 ("mt76: add driver for MT7603E and MT7628/7688") Signed-off-by: Abdun Nihaal Reviewed-by: Jiri Slaby Link: https://patch.msgid.link/20250709145532.41246-1-abdun.nihaal@gmail.com Signed-off-by: Felix Fietkau Signed-off-by: Sasha Levin --- drivers/net/wireless/mediatek/mt76/mt7603/soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/soc.c b/drivers/net/wireless/mediatek/mt76/mt7603/soc.c index 68efb300c0d88..8c3603f113894 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7603/soc.c +++ b/drivers/net/wireless/mediatek/mt76/mt7603/soc.c @@ -48,7 +48,7 @@ mt76_wmac_probe(struct platform_device *pdev) return 0; error: - ieee80211_free_hw(mt76_hw(dev)); + mt76_free_device(mdev); return ret; } -- 2.51.0