From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEB8B2BD033; Mon, 27 Oct 2025 18:42:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590556; cv=none; b=jOGfhF09D7N3hBMbKAtJ5+fqsE5TvnqIjLH1/2MsPvtX4+oeZ7I869zsr/wbPl/sLivgnw6R85MAD1H5x3FMPNeFcY5qB2FG9xSEL9NjzCmEP86PLT7lFZCRpiAcdpkKZKIM8uHSzLPL1GrmhDZ67fakYYxHoajZ2Yohek1RM5I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590556; c=relaxed/simple; bh=q2XiecuBY402K+QxBCZoXPpLKnkx7M1/qVyDgqP38AQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UCqTVHDsRp2WUEJMm93rnKT0JefJ2WZeM5v9Pv0EiOW6n63Dp0IE+RomEEk0cNGd/WYWfJVNXiyrsRWjEUidznhnZbSZFzf0/E7TmCBdg31tfX13ZdIYLfPInsJn3V/VNDWJGLG9J4/zqzr7Rf2VTc8FngjdOgB+ypw4ouZDPMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=YXZdYNAy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="YXZdYNAy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79A48C4CEFD; Mon, 27 Oct 2025 18:42:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761590555; bh=q2XiecuBY402K+QxBCZoXPpLKnkx7M1/qVyDgqP38AQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YXZdYNAyx0ubgDaB2SeLcJSzduRIZG+ZVkUMDsOSTxj2KFikOCYyCoUxwi2UC7rag V/li/yfskMHQpweNHfK4oj4sZWeIbySCwgYBVZ4+XirIz7qO7b31ywUi8qy0fwwNN2 NmyrIfBJP4E1s/C3pDcK0TETjtbdjaQwZOtH3jZ4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Duoming Zhou , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.4 088/224] scsi: mvsas: Fix use-after-free bugs in mvs_work_queue Date: Mon, 27 Oct 2025 19:33:54 +0100 Message-ID: <20251027183511.347212501@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183508.963233542@linuxfoundation.org> References: <20251027183508.963233542@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Duoming Zhou [ Upstream commit 60cd16a3b7439ccb699d0bf533799eeb894fd217 ] During the detaching of Marvell's SAS/SATA controller, the original code calls cancel_delayed_work() in mvs_free() to cancel the delayed work item mwq->work_q. However, if mwq->work_q is already running, the cancel_delayed_work() may fail to cancel it. This can lead to use-after-free scenarios where mvs_free() frees the mvs_info while mvs_work_queue() is still executing and attempts to access the already-freed mvs_info. A typical race condition is illustrated below: CPU 0 (remove) | CPU 1 (delayed work callback) mvs_pci_remove() | mvs_free() | mvs_work_queue() cancel_delayed_work() | kfree(mvi) | | mvi-> // UAF Replace cancel_delayed_work() with cancel_delayed_work_sync() to ensure that the delayed work item is properly canceled and any executing delayed work item completes before the mvs_info is deallocated. This bug was found by static analysis. Fixes: 20b09c2992fe ("[SCSI] mvsas: add support for 94xx; layout change; bug fixes") Signed-off-by: Duoming Zhou Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/mvsas/mv_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c index 264f32065ea7a..d0a6639c3542d 100644 --- a/drivers/scsi/mvsas/mv_init.c +++ b/drivers/scsi/mvsas/mv_init.c @@ -138,7 +138,7 @@ static void mvs_free(struct mvs_info *mvi) if (mvi->shost) scsi_host_put(mvi->shost); list_for_each_entry(mwq, &mvi->wq_list, entry) - cancel_delayed_work(&mwq->work_q); + cancel_delayed_work_sync(&mwq->work_q); kfree(mvi->rsvd_tags); kfree(mvi); } -- 2.51.0