From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28ACA33290A; Mon, 27 Oct 2025 18:47:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590829; cv=none; b=Ez/kTWxqT4CZACHzrlh5yTMH3H3OLNFZipX5dq8S62EQX9ZN3oB4dh0QUwRJwdcoMrWkk3GjGu4Z8OgxaFASRjCLh8q0J5NRZxnuxHYvBYLIFWDmeWCr5OnzqdSMb3LfaVqyJVxNlt6pddj3ewFHMn6tFqzoGtWnpVcYFYagFoQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590829; c=relaxed/simple; bh=9s/N/wZltcIChCOF5q9JeEB7lcpk1rAgl0kxyntVFF0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=O4KZ2nnKgkRlPIZrWDZva6jnFn/S9OmW9ONmBhzQKO6PglxOz66Z9VHsAbidC7dIycwu3oGXGC8cn5J+4qtGAErjp4dcCt9SIfMuVFzo2ARTGB+kN1gpI5N8zv8JeL2GBFj8U3RCUrJd7CHeSmNl0Ei/0/SvHksuE4QgYrS1FPk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=btYnYeBw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="btYnYeBw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 868FFC4CEFD; Mon, 27 Oct 2025 18:47:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761590829; bh=9s/N/wZltcIChCOF5q9JeEB7lcpk1rAgl0kxyntVFF0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=btYnYeBw0O8ZjRoFtIcHXzLQnWbImT3mGHjOjpceWFb6jNmRtnnUGlVc34vFh/Lfe t39YvOJwCPs1uWt/tecrPgZnYqjkCULl1zBhOn+lZmEFaUX0XOtAyK5ymfArtLTMX/ bMXCPZlf9FkabU0KZq2OnEgboGZ+ET5boHayMsRs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Michael=20Wei=C3=9F?= , Harshal Gohel , =?UTF-8?q?Johannes=20Wiesb=C3=B6ck?= , Ido Schimmel , Nikolay Aleksandrov , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 190/224] rtnetlink: Allow deleting FDB entries in user namespace Date: Mon, 27 Oct 2025 19:35:36 +0100 Message-ID: <20251027183513.912343597@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183508.963233542@linuxfoundation.org> References: <20251027183508.963233542@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johannes Wiesböck [ Upstream commit bf29555f5bdc017bac22ca66fcb6c9f46ec8788f ] Creating FDB entries is possible from a non-initial user namespace when having CAP_NET_ADMIN, yet, when deleting FDB entries, processes receive an EPERM because the capability is always checked against the initial user namespace. This restricts the FDB management from unprivileged containers. Drop the netlink_capable check in rtnl_fdb_del as it was originally dropped in c5c351088ae7 and reintroduced in 1690be63a27b without intention. This patch was tested using a container on GyroidOS, where it was possible to delete FDB entries from an unprivileged user namespace and private network namespace. Fixes: 1690be63a27b ("bridge: Add vlan support to static neighbors") Reviewed-by: Michael Weiß Tested-by: Harshal Gohel Signed-off-by: Johannes Wiesböck Reviewed-by: Ido Schimmel Reviewed-by: Nikolay Aleksandrov Link: https://patch.msgid.link/20251015201548.319871-1-johannes.wiesboeck@aisec.fraunhofer.de Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/core/rtnetlink.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 3d3743ef4f691..342b92afd1219 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -3836,9 +3836,6 @@ static int rtnl_fdb_del(struct sk_buff *skb, struct nlmsghdr *nlh, int err; u16 vid; - if (!netlink_capable(skb, CAP_NET_ADMIN)) - return -EPERM; - if (!del_bulk) { err = nlmsg_parse_deprecated(nlh, sizeof(*ndm), tb, NDA_MAX, NULL, extack); -- 2.51.0