From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C30D3218B2; Mon, 27 Oct 2025 18:47:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590851; cv=none; b=NO5+TGpU/zleLKOXqOs3G05VpOyv6o5wQMJjhib9MRFEEky4Fxyjq/Bc0BfGF0q7IuCGztmyxvge4RyfZv0uTga9cM07tz9ivwQH0cqNoOCBC0JuYmiV04l1T6jeIgoBKMP5zVvrwiOZ99JdVv8nkXIxSGeE9R3hsSuMiQtDbRk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590851; c=relaxed/simple; bh=UW5RhnSY3w5CyT+fRn3VcN2ucxNWLCtCvKSA2XzQIHg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XOM4rt3WQuw/cRGvhvgRWUSEC3kIJPrK/NhW3TGZFoNKmwdvlq7j/srV/hCdLCZFlBCvRBNT2F9tvd9pDjKHd8PCawuhkricmrm8nq2OCx5yAR9ghq6mTjuP8BUKfjnjknbIaadrrGwQidpyMiRXvoOPkJwXidLFElWqYoshBm4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=qKhwMpFC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="qKhwMpFC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75B5DC4CEF1; Mon, 27 Oct 2025 18:47:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1761590851; bh=UW5RhnSY3w5CyT+fRn3VcN2ucxNWLCtCvKSA2XzQIHg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qKhwMpFCEHGLIx5nkF98ncttBf5uyYx0xOMKEQZKaF6igRnrEnYPyGw/Gb8CSaegY YKTedNu8N82VWEthLrd72WSnmRsXOBhzhjFPrLB5o6iEUZonJ/IbGYQoOJNZlJvZVR C3P26Z19zv0QYMFORqQAildA9nNFga/JwZh4XQXA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Deepanshu Kartikey , syzbot+6fdd8fa3380730a4b22c@syzkaller.appspotmail.com, Mark Fasheh , Joseph Qi , Joel Becker , Junxiao Bi , Changwei Ge , Jun Piao , Andrew Morton Subject: [PATCH 5.4 197/224] ocfs2: clear extent cache after moving/defragmenting extents Date: Mon, 27 Oct 2025 19:35:43 +0100 Message-ID: <20251027183514.082921582@linuxfoundation.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251027183508.963233542@linuxfoundation.org> References: <20251027183508.963233542@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Deepanshu Kartikey commit 78a63493f8e352296dbc7cb7b3f4973105e8679e upstream. The extent map cache can become stale when extents are moved or defragmented, causing subsequent operations to see outdated extent flags. This triggers a BUG_ON in ocfs2_refcount_cal_cow_clusters(). The problem occurs when: 1. copy_file_range() creates a reflinked extent with OCFS2_EXT_REFCOUNTED 2. ioctl(FITRIM) triggers ocfs2_move_extents() 3. __ocfs2_move_extents_range() reads and caches the extent (flags=0x2) 4. ocfs2_move_extent()/ocfs2_defrag_extent() calls __ocfs2_move_extent() which clears OCFS2_EXT_REFCOUNTED flag on disk (flags=0x0) 5. The extent map cache is not invalidated after the move 6. Later write() operations read stale cached flags (0x2) but disk has updated flags (0x0), causing a mismatch 7. BUG_ON(!(rec->e_flags & OCFS2_EXT_REFCOUNTED)) triggers Fix by clearing the extent map cache after each extent move/defrag operation in __ocfs2_move_extents_range(). This ensures subsequent operations read fresh extent data from disk. Link: https://lore.kernel.org/all/20251009142917.517229-1-kartikey406@gmail.com/T/ Link: https://lkml.kernel.org/r/20251009154903.522339-1-kartikey406@gmail.com Fixes: 53069d4e7695 ("Ocfs2/move_extents: move/defrag extents within a certain range.") Signed-off-by: Deepanshu Kartikey Reported-by: syzbot+6fdd8fa3380730a4b22c@syzkaller.appspotmail.com Tested-by: syzbot+6fdd8fa3380730a4b22c@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?id=2959889e1f6e216585ce522f7e8bc002b46ad9e7 Reviewed-by: Mark Fasheh Reviewed-by: Joseph Qi Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Jun Piao Cc: Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- fs/ocfs2/move_extents.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/fs/ocfs2/move_extents.c +++ b/fs/ocfs2/move_extents.c @@ -870,6 +870,11 @@ static int __ocfs2_move_extents_range(st mlog_errno(ret); goto out; } + /* + * Invalidate extent cache after moving/defragging to prevent + * stale cached data with outdated extent flags. + */ + ocfs2_extent_map_trunc(inode, cpos); context->clusters_moved += alloc_size; next: