Re: [PATCH v2 01/15] dt-bindings: regulator: ROHM BD72720

[Rob Herring <robh@kernel.org>]

On Mon, Oct 27, 2025 at 01:44:49PM +0200, Matti Vaittinen wrote:
> The ROHM BD72720 is a new PMIC with 10 BUCk and 11 LDO regulators.
> 
> The BD72720 is designed to support using the BUCK10 as a supply for
> the LDOs 1 to 4. When the BUCK10 is used for this, it can be set to a
> LDON_HEAD mode. In this mode, the BUCK10 voltage can't be controlled by
> software, but the voltage is adjusted by PMIC to match the LDO1 .. LDO4
> voltages with a given offset. Offset can be 50mV .. 300mV and is
> changeable at 50mV steps.
> 
> Add 'ldon-head-millivolt' property to denote a board which is designed
> to utilize the LDON_HEAD mode.
> 
> All other properties are already existing.
> 
> Add dt-binding doc for ROHM BD72720 regulators to make it usable.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> 
> ---
> Revision history:
>  RFCv1 =>:
>  - No changes
> ---
>  .../regulator/rohm,bd72720-regulator.yaml     | 153 ++++++++++++++++++
>  1 file changed, 153 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.yaml b/Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.yaml
> new file mode 100644
> index 000000000000..665086f56928
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.yaml
> @@ -0,0 +1,153 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/rohm,bd72720-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ROHM BD72720 Power Management Integrated Circuit regulators
> +
> +maintainers:
> +  - Matti Vaittinen <mazziesaccount@gmail.com>
> +
> +description: |
> +  This module is part of the ROHM BD72720 MFD device. For more details
> +  see Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml.
> +
> +  The regulator controller is represented as a sub-node of the PMIC node
> +  on the device tree.
> +
> +  Regulator nodes should be named to BUCK_<number> and LDO_<number>.
> +  The valid names for BD72720 regulator nodes are
> +  buck1, buck2, buck3, buck4, buck5, buck6, buck7, buck8, buck9, buck10
> +  ldo1, ldo2, ldo3, ldo4, ldo5, ldo6, ldo7, ldo8, ldo9, ldo10, ldo11
> +
> +patternProperties:
> +  "^ldo[1-11]$":
> +    type: object
> +    description:
> +      Properties for single LDO regulator.
> +    $ref: regulator.yaml#
> +
> +    properties:
> +      regulator-name:
> +        pattern: "^ldo[1-11]$"
> +        description:
> +          should be "ldo1", ..., "ldo11"

No need to repeat in prose what the schema says.

> +
> +      rohm,dvs-run-voltage:
> +        description:
> +          PMIC default "RUN" state voltage in uV. See below table for
> +          LDOs which support this. 0 means disabled.
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 0
> +        maximum: 3300000
> +
> +      rohm,dvs-idle-voltage:
> +        description:
> +          PMIC default "IDLE" state voltage in uV. See below table for
> +          LDOs which support this. 0 means disabled.
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 0
> +        maximum: 3300000
> +
> +      rohm,dvs-suspend-voltage:
> +        description:
> +          PMIC default "SUSPEND" state voltage in uV. See below table for
> +          LDOs which support this. 0 means disabled.
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 0
> +        maximum: 3300000
> +
> +      rohm,dvs-lpsr-voltage:
> +        description:
> +          PMIC default "deep-idle" state voltage in uV. See below table for
> +          LDOs which support this. 0 means disabled.
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 0
> +        maximum: 3300000
> +
> +        # Supported default DVS states:
> +        #     ldo        |    run     |   idle    | suspend   | lpsr
> +        # --------------------------------------------------------------
> +        # 1, 2, 3, and 4 | supported  | supported | supported | supported
> +        # --------------------------------------------------------------
> +        # 5 - 11         |                    supported (*)
> +        # --------------------------------------------------------------
> +        #
> +        # (*) All states use same voltage but have own enable / disable
> +        #      settings. Voltage 0 can be specified for a state to make
> +        #      regulator disabled on that state.
> +
> +    unevaluatedProperties: false
> +
> +  "^buck[1-10]$":
> +    type: object
> +    description:
> +      Properties for single BUCK regulator.
> +    $ref: regulator.yaml#
> +
> +    properties:
> +      regulator-name:
> +        pattern: "^buck[1-10]$"
> +        description:
> +          should be "buck1", ..., "buck10"

Same here.

> +
> +      rohm,ldon-head-millivolt:

Use standard unit-suffixes. (-microvolt)

> +        description:
> +          Set this on boards where BUCK10 is used to supply LDOs 1-4. The bucki
> +          voltage will be changed by the PMIC to follow the LDO output voltages
> +          with the offset voltage given here. This will improve the LDO efficiency.
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 50
> +        maximum: 300
> +
> +      rohm,dvs-run-voltage:
> +        description:
> +          PMIC default "RUN" state voltage in uV. See below table for
> +          bucks which support this. 0 means disabled.
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 0
> +        maximum: 3300000
> +
> +      rohm,dvs-idle-voltage:
> +        description:
> +          PMIC default "IDLE" state voltage in uV. See below table for
> +          bucks which support this. 0 means disabled.
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 0
> +        maximum: 3300000
> +
> +      rohm,dvs-suspend-voltage:
> +        description:
> +          PMIC default "SUSPEND" state voltage in uV. See below table for
> +          bucks which support this. 0 means disabled.
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 0
> +        maximum: 3300000
> +
> +      rohm,dvs-lpsr-voltage:
> +        description:
> +          PMIC default "deep-idle" state voltage in uV. See below table for
> +          bucks which support this. 0 means disabled.
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 0
> +        maximum: 3300000
> +
> +        # Supported default DVS states:
> +        #     buck       |    run     |   idle    | suspend   | lpsr
> +        # --------------------------------------------------------------
> +        # 1, 2, 3, and 4 | supported  | supported | supported | supported
> +        # --------------------------------------------------------------
> +        # 5 - 10    |                    supported (*)
> +        # --------------------------------------------------------------
> +        #
> +        # (*) All states use same voltage but have own enable / disable
> +        #      settings. Voltage 0 can be specified for a state to make
> +        #      regulator disabled on that state.
> +
> +    required:
> +      - regulator-name
> +
> +    unevaluatedProperties: false
> +
> +additionalProperties: false
> -- 
> 2.51.0
>