From: Joel Fernandes <joelagnelf@nvidia.com>
To: John Hubbard <jhubbard@nvidia.com>
Cc: "Danilo Krummrich" <dakr@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Edwin Peer" <epeer@nvidia.com>, "Zhi Wang" <zhiw@nvidia.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] gpu: nova: add boot42 support for next-gen GPUs
Date: Mon, 27 Oct 2025 17:21:33 -0400 [thread overview]
Message-ID: <20251027212133.GA298309@joelbox2> (raw)
In-Reply-To: <50acc826-dbe7-42bf-9645-ad5aa47a3d17@nvidia.com>
On Sat, Oct 25, 2025 at 10:32:35AM -0700, John Hubbard wrote:
> On 10/25/25 3:01 AM, Danilo Krummrich wrote:
> > On Sat Oct 25, 2025 at 2:14 AM CEST, John Hubbard wrote:
> ...> Why open code all of the above in the struct Gpu constructor? This
> could all
> > happen within Spec::new().
> >
>
> OK, yes, that does help avoid cluttering up Gpu::new().
+1.
Also, it bloats up the dev_info! print in Gpu::new() to those.
Spec can encapsulate the boot0 vs boot42 code, and any further changes.
But otherwise, the boot0 vs boot42 code in the patchset look good to me.
thanks,
- Joel
prev parent reply other threads:[~2025-10-27 21:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-25 0:14 [PATCH 0/2] gpu: nova: add boot42 support for next-gen GPUs John Hubbard
2025-10-25 0:14 ` [PATCH 1/2] gpu: nova: remove Spec and Revision types John Hubbard
2025-10-25 10:01 ` Danilo Krummrich
2025-10-25 17:27 ` John Hubbard
2025-10-25 0:14 ` [PATCH 2/2] gpu: nova: add boot42 support for next-gen GPUs John Hubbard
2025-10-25 10:01 ` Danilo Krummrich
2025-10-25 17:32 ` John Hubbard
2025-10-27 21:21 ` Joel Fernandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027212133.GA298309@joelbox2 \
--to=joelagnelf@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=epeer@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.