All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: rafiqul713 <rafiqul713@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH] [PATCH v3] staging: rtl8723bs: remove unused rtw_sprintf macro
Date: Tue, 28 Oct 2025 10:06:09 +0100	[thread overview]
Message-ID: <2025102840-shivering-quartet-3b3e@gregkh> (raw)
In-Reply-To: <20251028085811.20831-1-rafiqul713@gmail.com>

On Tue, Oct 28, 2025 at 09:58:11AM +0100, rafiqul713 wrote:
> From: Rafiqul Islam <rafiqul713@gmail.com>
> 
> The rtw_sprintf macro is defined in osdep_service.h but has no callers in
> the driver. Remove the dead code.
> 
> Changes since v2:
> - Addressed review feedback to delete the macro instead of replacing it

As per the docs, this needs to go below the --- line.

Also, you have PATCH twice in the subject line :(

v4 perhaps?

thanks,

greg k-h

      reply	other threads:[~2025-10-28  9:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28  8:58 [PATCH] [PATCH v3] staging: rtl8723bs: remove unused rtw_sprintf macro rafiqul713
2025-10-28  9:06 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025102840-shivering-quartet-3b3e@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=rafiqul713@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.