From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Max Gurtovoy <mgurtovoy@nvidia.com>,
hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me,
kch@nvidia.com, dwagner@suse.de, israelr@nvidia.com
Subject: Re: [PATCH 0/4] nvmet: fix configfs attr update handling for discovered subsystems
Date: Wed, 29 Oct 2025 10:32:32 +0100 [thread overview]
Message-ID: <20251029093232.GA791@lst.de> (raw)
In-Reply-To: <aNRtJZL7uxRaHifz@kbusch-mbp>
On Wed, Sep 24, 2025 at 04:13:57PM -0600, Keith Busch wrote:
> On Wed, Sep 24, 2025 at 11:26:00PM +0300, Max Gurtovoy wrote:
> > 1. Forbid changes to controller ID min/max attributes values on already
> > discovered subsystems.
> > 2. Switch cntlid ida allocation from global to per-subsystem scope,
> > matching the granularity of controller ID ranges.
> > 3. Forbid changes to vendor ID and subsystem vendor ID attributes values
> > on already discovered subsystems.
> > 4. Forbid changes to max_qid attribute values on already discovered
> > subsystems.
>
> Is there a reason these should be changeable after they're initialized
> even prior to being discovered?
Yes, the whole idea of allowing modifications when enabled, but not
discovered seems odd.
This seems to come from:
commit 87fd4cc1c0dda038c9a3617c9d07d5159326e80f
Author: Noam Gottlieb <ngottlieb@nvidia.com>
Date: Mon Jun 7 12:23:24 2021 +0300
nvmet: make ver stable once connection established
I really think we should try to replace all that with an enable
check, hoping we're not going to break something that started to
rely on it.
prev parent reply other threads:[~2025-10-29 9:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 20:26 [PATCH 0/4] nvmet: fix configfs attr update handling for discovered subsystems Max Gurtovoy
2025-09-24 20:26 ` [PATCH 1/4] nvmet: forbid changing ctrl ID attributes " Max Gurtovoy
2025-09-24 20:26 ` [PATCH 2/4] nvmet: make cntlid ida per subsystem Max Gurtovoy
2025-09-24 20:26 ` [PATCH 3/4] nvmet: prevent max_qid changes for discovered subsystems Max Gurtovoy
2025-09-25 7:36 ` Daniel Wagner
2025-09-25 8:28 ` Max Gurtovoy
2025-09-25 11:32 ` Daniel Wagner
2025-09-25 12:06 ` Max Gurtovoy
2025-09-25 16:02 ` Daniel Wagner
2025-09-25 22:09 ` Max Gurtovoy
2025-09-26 6:58 ` Daniel Wagner
2025-09-28 11:53 ` Max Gurtovoy
2025-10-01 6:04 ` Daniel Wagner
2025-09-24 20:26 ` [PATCH 4/4] nvmet: prevent vid/ssvid " Max Gurtovoy
2025-09-24 22:13 ` [PATCH 0/4] nvmet: fix configfs attr update handling " Keith Busch
2025-09-28 13:31 ` Max Gurtovoy
2025-10-08 22:56 ` Max Gurtovoy
2025-10-29 9:32 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029093232.GA791@lst.de \
--to=hch@lst.de \
--cc=dwagner@suse.de \
--cc=israelr@nvidia.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.