From: Christoph Hellwig <hch@lst.de>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: linux-nvme@lists.infradead.org, hare@suse.de, kbusch@kernel.org,
hch@lst.de, sagi@grimberg.me, dwagner@suse.de, axboe@kernel.dk,
gjoyce@ibm.com
Subject: Re: [RFC PATCHv3 1/6] block: expose blk_stat_{enable,disable}_accounting() to drivers
Date: Wed, 29 Oct 2025 10:39:34 +0100 [thread overview]
Message-ID: <20251029093934.GB1066@lst.de> (raw)
In-Reply-To: <20251027092949.961287-2-nilay@linux.ibm.com>
On Mon, Oct 27, 2025 at 02:59:35PM +0530, Nilay Shroff wrote:
> The functions blk_stat_enable_accounting() and
> blk_stat_disable_accounting() are currently exported, but their
> prototypes are only defined in a private header. Move these prototypes
> into a common header so that block drivers can directly use these APIs.
That's because they are only used by I/O scheduler, which are the only
valid users. I don't think drivers should touch this, but I'll stay
tuned..
next prev parent reply other threads:[~2025-10-29 9:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 9:29 [RFC PATCHv3 0/6] nvme-multipath: introduce adaptive I/O policy Nilay Shroff
2025-10-27 9:29 ` [RFC PATCHv3 1/6] block: expose blk_stat_{enable,disable}_accounting() to drivers Nilay Shroff
2025-10-29 9:39 ` Christoph Hellwig [this message]
2025-10-29 16:40 ` Nilay Shroff
2025-10-27 9:29 ` [RFC PATCHv3 2/6] nvme-multipath: add support for adaptive I/O policy Nilay Shroff
2025-10-27 11:34 ` Hannes Reinecke
2025-10-27 12:09 ` Nilay Shroff
2025-10-29 9:40 ` Christoph Hellwig
2025-10-29 14:21 ` Nilay Shroff
2025-10-27 9:29 ` [RFC PATCHv3 3/6] nvme: add sysfs attribute adp_ewma_shift Nilay Shroff
2025-10-27 11:54 ` Hannes Reinecke
2025-10-27 9:29 ` [RFC PATCHv3 4/6] nvme: add sysfs attribute adp_weight_timeout Nilay Shroff
2025-10-27 11:54 ` Hannes Reinecke
2025-10-27 9:29 ` [RFC PATCHv3 5/6] nvme: add generic debugfs support Nilay Shroff
2025-10-27 11:55 ` Hannes Reinecke
2025-10-27 12:02 ` Nilay Shroff
2025-10-27 9:29 ` [RFC PATCHv3 6/6] nvme-multipath: add debugfs attribute for adaptive I/O policy stat Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029093934.GB1066@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=gjoyce@ibm.com \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.