diff for duplicates of <202510291226.2R3fbYNh-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index cbbfc51..34fd97c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,36 +1,20 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -CC: linux-kernel@vger.kernel.org -TO: Niranjan H Y <niranjan.hy@ti.com> -CC: Mark Brown <broonie@kernel.org> -CC: Bard Liao <yung-chuan.liao@linux.intel.com> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 8eefed8f65cc17c31fdf4ab32292b794b34893ad commit: 4cc9bd8d7b32d59b86cb489a96aa8a7b9dd6a21b ASoc: tas2783A: Add soundwire based codec driver -date: 5 weeks ago -:::::: branch date: 9 hours ago -:::::: commit date: 5 weeks ago config: arm64-randconfig-r073-20251029 (https://download.01.org/0day-ci/archive/20251029/202510291226.2R3fbYNh-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 14.3.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> -| Reported-by: Dan Carpenter <error27@gmail.com> +| Reported-by: Dan Carpenter <dan.carpenter@linaro.org> | Closes: https://lore.kernel.org/r/202510291226.2R3fbYNh-lkp@intel.com/ New smatch warnings: sound/soc/codecs/tas2783-sdw.c:814 tas2783_fw_ready() error: uninitialized symbol 'ret'. -sound/soc/codecs/tas2783-sdw.c:848 tas_fu21_event() error: uninitialized symbol 'mute'. -sound/soc/codecs/tas2783-sdw.c:870 tas_fu23_event() error: uninitialized symbol 'mute'. - -Old smatch warnings: -sound/soc/codecs/tas2783-sdw.c:1288 tas_sdw_probe() warn: passing zero to 'PTR_ERR' vim +/ret +814 sound/soc/codecs/tas2783-sdw.c -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 747 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 748 static void tas2783_fw_ready(const struct firmware *fmw, void *context) 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 749 { 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 750 struct tas2783_prv *tas_dev = @@ -53,6 +37,9 @@ vim +/ret +814 sound/soc/codecs/tas2783-sdw.c 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 767 buf = fmw->data; 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 768 offset += FW_DL_OFFSET; 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 769 while (offset < (img_sz - FW_FL_HDR)) { + +If the firmware is too small the "ret" value might be uninitialized. + 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 770 memset(&hdr, 0, sizeof(hdr)); 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 771 offset += read_header(&buf[offset], &hdr); 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 772 dev_dbg(tas_dev->dev, @@ -98,64 +85,15 @@ vim +/ret +814 sound/soc/codecs/tas2783-sdw.c 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 812 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 813 out: 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 @814 if (!ret) + ^^^^ +Here. + 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 815 tas_dev->fw_dl_success = true; 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 816 tas_dev->fw_dl_task_done = true; 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 817 wake_up(&tas_dev->fw_wait); 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 818 if (fmw) 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 819 release_firmware(fmw); 4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 820 } -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 821 -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 822 static inline s32 tas_clear_latch(struct tas2783_prv *priv) -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 823 { -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 824 return regmap_update_bits(priv->regmap, -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 825 TASDEV_REG_SDW(0, 0, 0x5c), -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 826 0x04, 0x04); -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 827 } -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 828 -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 829 static s32 tas_fu21_event(struct snd_soc_dapm_widget *w, -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 830 struct snd_kcontrol *k, s32 event) -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 831 { -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 832 struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 833 struct tas2783_prv *tas_dev = snd_soc_component_get_drvdata(component); -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 834 s32 mute; -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 835 -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 836 switch (event) { -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 837 case SND_SOC_DAPM_POST_PMU: -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 838 mute = 0; -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 839 break; -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 840 -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 841 case SND_SOC_DAPM_PRE_PMD: -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 842 mute = 1; -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 843 break; -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 844 } -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 845 -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 846 return sdw_write_no_pm(tas_dev->sdw_peripheral, -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 847 SDW_SDCA_CTL(1, TAS2783_SDCA_ENT_FU21, -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 @848 TAS2783_SDCA_CTL_FU_MUTE, 1), mute); -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 849 } -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 850 -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 851 static s32 tas_fu23_event(struct snd_soc_dapm_widget *w, -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 852 struct snd_kcontrol *k, s32 event) -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 853 { -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 854 struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 855 struct tas2783_prv *tas_dev = snd_soc_component_get_drvdata(component); -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 856 s32 mute; -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 857 -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 858 switch (event) { -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 859 case SND_SOC_DAPM_POST_PMU: -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 860 mute = 0; -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 861 break; -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 862 -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 863 case SND_SOC_DAPM_PRE_PMD: -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 864 mute = 1; -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 865 break; -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 866 } -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 867 -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 868 return sdw_write_no_pm(tas_dev->sdw_peripheral, -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 869 SDW_SDCA_CTL(1, TAS2783_SDCA_ENT_FU23, -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 @870 TAS2783_SDCA_CTL_FU_MUTE, 1), mute); -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 871 } -4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 872 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index a64a6c5..fb385f1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,44 +1,32 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@linaro.org>\0" "Subject\0sound/soc/codecs/tas2783-sdw.c:814 tas2783_fw_ready() error: uninitialized symbol 'ret'.\0" - "Date\0Wed, 29 Oct 2025 12:36:53 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Wed, 29 Oct 2025 11:06:46 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Niranjan H Y <niranjan.hy@ti.com>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + oe-kbuild-all@lists.linux.dev + linux-kernel@vger.kernel.org + Mark Brown <broonie@kernel.org> + " Bard Liao <yung-chuan.liao@linux.intel.com>\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "CC: linux-kernel@vger.kernel.org\n" - "TO: Niranjan H Y <niranjan.hy@ti.com>\n" - "CC: Mark Brown <broonie@kernel.org>\n" - "CC: Bard Liao <yung-chuan.liao@linux.intel.com>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master\n" "head: 8eefed8f65cc17c31fdf4ab32292b794b34893ad\n" "commit: 4cc9bd8d7b32d59b86cb489a96aa8a7b9dd6a21b ASoc: tas2783A: Add soundwire based codec driver\n" - "date: 5 weeks ago\n" - ":::::: branch date: 9 hours ago\n" - ":::::: commit date: 5 weeks ago\n" "config: arm64-randconfig-r073-20251029 (https://download.01.org/0day-ci/archive/20251029/202510291226.2R3fbYNh-lkp@intel.com/config)\n" "compiler: aarch64-linux-gcc (GCC) 14.3.0\n" "\n" "If you fix the issue in a separate patch/commit (i.e. not just a new version of\n" "the same patch/commit), kindly add following tags\n" "| Reported-by: kernel test robot <lkp@intel.com>\n" - "| Reported-by: Dan Carpenter <error27@gmail.com>\n" + "| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>\n" "| Closes: https://lore.kernel.org/r/202510291226.2R3fbYNh-lkp@intel.com/\n" "\n" "New smatch warnings:\n" "sound/soc/codecs/tas2783-sdw.c:814 tas2783_fw_ready() error: uninitialized symbol 'ret'.\n" - "sound/soc/codecs/tas2783-sdw.c:848 tas_fu21_event() error: uninitialized symbol 'mute'.\n" - "sound/soc/codecs/tas2783-sdw.c:870 tas_fu23_event() error: uninitialized symbol 'mute'.\n" - "\n" - "Old smatch warnings:\n" - "sound/soc/codecs/tas2783-sdw.c:1288 tas_sdw_probe() warn: passing zero to 'PTR_ERR'\n" "\n" "vim +/ret +814 sound/soc/codecs/tas2783-sdw.c\n" "\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 747 \n" "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 748 static void tas2783_fw_ready(const struct firmware *fmw, void *context)\n" "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 749 {\n" "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 750 \tstruct tas2783_prv *tas_dev =\n" @@ -61,6 +49,9 @@ "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 767 \tbuf = fmw->data;\n" "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 768 \toffset += FW_DL_OFFSET;\n" "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 769 \twhile (offset < (img_sz - FW_FL_HDR)) {\n" + "\n" + "If the firmware is too small the \"ret\" value might be uninitialized.\n" + "\n" "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 770 \t\tmemset(&hdr, 0, sizeof(hdr));\n" "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 771 \t\toffset += read_header(&buf[offset], &hdr);\n" "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 772 \t\tdev_dbg(tas_dev->dev,\n" @@ -106,67 +97,18 @@ "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 812 \n" "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 813 out:\n" "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 @814 \tif (!ret)\n" + " ^^^^\n" + "Here.\n" + "\n" "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 815 \t\ttas_dev->fw_dl_success = true;\n" "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 816 \ttas_dev->fw_dl_task_done = true;\n" "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 817 \twake_up(&tas_dev->fw_wait);\n" "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 818 \tif (fmw)\n" "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 819 \t\trelease_firmware(fmw);\n" "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 820 }\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 821 \n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 822 static inline s32 tas_clear_latch(struct tas2783_prv *priv)\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 823 {\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 824 \treturn regmap_update_bits(priv->regmap,\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 825 \t\t\t\t TASDEV_REG_SDW(0, 0, 0x5c),\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 826 \t\t\t\t 0x04, 0x04);\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 827 }\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 828 \n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 829 static s32 tas_fu21_event(struct snd_soc_dapm_widget *w,\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 830 \t\t\t struct snd_kcontrol *k, s32 event)\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 831 {\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 832 \tstruct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 833 \tstruct tas2783_prv *tas_dev = snd_soc_component_get_drvdata(component);\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 834 \ts32 mute;\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 835 \n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 836 \tswitch (event) {\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 837 \tcase SND_SOC_DAPM_POST_PMU:\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 838 \t\tmute = 0;\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 839 \t\tbreak;\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 840 \n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 841 \tcase SND_SOC_DAPM_PRE_PMD:\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 842 \t\tmute = 1;\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 843 \t\tbreak;\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 844 \t}\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 845 \n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 846 \treturn sdw_write_no_pm(tas_dev->sdw_peripheral,\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 847 \t\t\t SDW_SDCA_CTL(1, TAS2783_SDCA_ENT_FU21,\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 @848 \t\t\t\t\t TAS2783_SDCA_CTL_FU_MUTE, 1), mute);\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 849 }\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 850 \n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 851 static s32 tas_fu23_event(struct snd_soc_dapm_widget *w,\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 852 \t\t\t struct snd_kcontrol *k, s32 event)\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 853 {\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 854 \tstruct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 855 \tstruct tas2783_prv *tas_dev = snd_soc_component_get_drvdata(component);\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 856 \ts32 mute;\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 857 \n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 858 \tswitch (event) {\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 859 \tcase SND_SOC_DAPM_POST_PMU:\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 860 \t\tmute = 0;\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 861 \t\tbreak;\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 862 \n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 863 \tcase SND_SOC_DAPM_PRE_PMD:\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 864 \t\tmute = 1;\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 865 \t\tbreak;\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 866 \t}\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 867 \n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 868 \treturn sdw_write_no_pm(tas_dev->sdw_peripheral,\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 869 \t\t\t SDW_SDCA_CTL(1, TAS2783_SDCA_ENT_FU23,\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 @870 \t\t\t\t\t TAS2783_SDCA_CTL_FU_MUTE, 1), mute);\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 871 }\n" - "4cc9bd8d7b32d5 Niranjan H Y 2025-09-12 872 \n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -4aac12bc6a5d96ce4546dd2fdabc1e0d2c95059c56afac7f73839305bb593c65 +c19fd46b117f0ce3434d761194ae895a2d730adbdc83e296bbf5ea8c7d6b924c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.