From: Jakub Kicinski <kuba@kernel.org>
To: Jonas Gorski <jonas.gorski@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: "Vladimir Oltean" <olteanv@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Álvaro Fernández Rojas" <noltari@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: dsa: tag_brcm: legacy: fix untagged rx on unbridged ports for bcm63xx
Date: Wed, 29 Oct 2025 18:12:16 -0700 [thread overview]
Message-ID: <20251029181216.3f35f8ba@kernel.org> (raw)
In-Reply-To: <CAOiHx=nw-phPcRPRmHd6wJ5XksxXn9kRRoTuqH4JZeKHfxzD5A@mail.gmail.com>
On Tue, 28 Oct 2025 11:15:23 +0100 Jonas Gorski wrote:
> > Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
> >
> > Sorry for dropping the ball on v1. To reply to your reply there,
> > https://lore.kernel.org/netdev/CAOiHx=mNnMJTnAN35D6=LPYVTQB+oEmedwqrkA6VRLRVi13Kjw@mail.gmail.com/
> > I hadn't realized that b53 sets ds->untag_bridge_pvid conditionally,
> > which makes any consolidation work in stable trees very complicated
> > (although still desirable in net-next).
>
> It's for some more obscure cases where we cannot use the Broadcom tag,
> like a switch where the CPU port isn't a management port but a normal
> port. I am not sure this really exists, but maybe Florian knows if
> there are any (still used) boards where this applies.
>
> If not, I am more than happy to reject this path as -EINVAL instead of
> the current TAG_NONE with untag_bridge_pvid = true.
IIUC Vladimir is okay with the patch but I realized now that Florian
is not even CCed here, and ack would be good. Adding him now. And we
should probably add a MAINTAINERS entry for tag_brcm to avoid this in
the future?
next prev parent reply other threads:[~2025-10-30 1:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 19:46 [PATCH net v2] net: dsa: tag_brcm: legacy: fix untagged rx on unbridged ports for bcm63xx Jonas Gorski
2025-10-27 21:15 ` Vladimir Oltean
2025-10-28 10:15 ` Jonas Gorski
2025-10-30 1:12 ` Jakub Kicinski [this message]
2025-11-01 10:32 ` Jonas Gorski
2025-11-03 22:11 ` Florian Fainelli
2025-10-31 23:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029181216.3f35f8ba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=horms@kernel.org \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.