Re: [meta-ti][scarthgap][PATCH v5] ti-librpmsg-dma: update ti-librpmsg-dma SRCREV & LICENSE

[Denys Dmytriyenko <denis@denix.org>]

On Wed, Oct 29, 2025 at 11:32:09AM +0530, Vishnu Singh via lists.yoctoproject.org wrote:
> From: Vishnu Singh <v-singh1@ti.com>
> 
> Replace MIT license with TI-TFL to align with TI release policy
> and product requirements. Legal approval: SRAS00013045
> Update scarthgap srcrev and disable 2dfft example from lib build.
> 
> License-Update: Replace MIT to TI-TFL license

Sorry to be pedantic and blunt, but that's not the reason, that's tautology.

License-Update tag (and the commit message in general) must answer the "Why?" 
question, not the "What?" question. We can all see the "What?" question being 
answered by the code change itself. There's no need to repeat that with the 
"changing X to Y". You need to explain why you are changing X to Y...


> Signed-off-by: Vishnu Singh <v-singh1@ti.com>
> ---
> Change log:
>        v1->v2:
>               - Update commit message with license-update
>        v2->v3:
>               - Update SRCREV (license updated in README) 
>        v3->v4:
>               - Add branch name in patch subject 
>        v4->v5:
>               - Update latest SRCREV 
> 
>  meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb b/meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb
> index b624871d..7600f867 100644
> --- a/meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb
> +++ b/meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb
> @@ -1,9 +1,9 @@
>  SUMMARY = "RPMsg DMA shared library"
> -LICENSE = "MIT"
> -LIC_FILES_CHKSUM = "file://LICENSE;md5=744e63d2bb8c6151dcdd97f49aa02c53"
> +LICENSE = "TI-TFL"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=91dc4ee6d125d0aaba4e5bd2fcc50ed3"
>  
> -SRC_URI = "git://github.com/TexasInstruments/rpmsg-dma.git;protocol=https;branch=main"
> -SRCREV = "609fd72f458ba56f80d06810509ef88d010d2c03"
> +SRC_URI = "git://github.com/TexasInstruments/rpmsg-dma.git;protocol=https;branch=scarthgap"
> +SRCREV = "153951932925a72346b76d98b2774952c48a82fc"
>  
>  S = "${WORKDIR}/git"
>  
> @@ -11,6 +11,6 @@ inherit cmake
>  
>  DEPENDS = "ti-rpmsg-char"
>  
> -EXTRA_OECMAKE += "-DBUILD_LIB=ON -DBUILD_EXAMPLE=OFF"
> +EXTRA_OECMAKE += "-DBUILD_LIB=ON -DBUILD_AUDIO_OFFLOAD_EXAMPLE=OFF -DBUILD_2DFFT_OFFLOAD_EXAMPLE=OFF"
>  
>  COMPATIBLE_MACHINE = "^(k3)$"
> -- 
> 2.50.1