Re: [PATCH 1/1] NFSD: Fix problem with nfsd4_scsi_fence_client using the wrong reservation type

[Christoph Hellwig <hch@lst.de>]

On Wed, Oct 29, 2025 at 04:28:26PM -0700, Dai Ngo wrote:
> The reservation type argument for the pr_preempt call should match the
> one used in nfsd4_block_get_device_info_scsi. Additionally, the pr_preempt
> operation only needs to be executed once per SCSI target.

One patch per change, please.

Also please add a Fixes: tag.

> 
> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
> ---
>  fs/nfsd/blocklayout.c | 17 +++++++++++++++--
>  fs/nfsd/state.h       |  1 +
>  2 files changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfsd/blocklayout.c b/fs/nfsd/blocklayout.c
> index fde5539cf6a6..4ca6cb420736 100644
> --- a/fs/nfsd/blocklayout.c
> +++ b/fs/nfsd/blocklayout.c
> @@ -340,9 +340,22 @@ nfsd4_scsi_fence_client(struct nfs4_layout_stateid *ls, struct nfsd_file *file)
>  {
>  	struct nfs4_client *clp = ls->ls_stid.sc_client;
>  	struct block_device *bdev = file->nf_file->f_path.mnt->mnt_sb->s_bdev;
> +	int error;
> +
> +	if (ls->ls_fenced)
> +		return;
> +	ls->ls_fenced = true;

What is used to serialize this?

> +		ls->ls_fenced = false;
> +		rpc_ntop((struct sockaddr *)&clp->cl_addr, addr_str, sizeof(addr_str));

Overly long line.

> +		dprintk("nfsd: failed to fence client %s error %d\n",
> +			addr_str, error);
> +	}

Also the error printing is new without any rationale in the commit
message.