From: Stefan Hajnoczi <stefanha@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
hibriansong@gmail.com, qemu-block@nongnu.org,
Hanna Czenczek <hreitz@redhat.com>,
eblake@redhat.com
Subject: Re: [PATCH v5 00/12] aio: add the aio_add_sqe() io_uring API
Date: Thu, 30 Oct 2025 11:15:43 -0400 [thread overview]
Message-ID: <20251030151543.GA462334@fedora> (raw)
In-Reply-To: <aQN5q47Lw2Bv8I_X@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1500 bytes --]
On Thu, Oct 30, 2025 at 03:43:55PM +0100, Kevin Wolf wrote:
> Am 29.10.2025 um 21:33 hat Stefan Hajnoczi geschrieben:
> > v5:
> > - Explain how fdmon-io_uring.c differs from other fdmon implementations
> > in commit message [Kevin]
> > - Move test-nested-aio-poll aio_get_g_source() removal into commit that touches test case [Kevin]
> > - Avoid g_source_add_poll() use-after-free in fdmon_poll_update() [Kevin]
> > - Avoid duplication in fdmon_epoll_gsource_dispatch(), use fdmon_epoll_wait() [Kevin]
> > - Drop unnecessary revents checks in fdmon_poll_gsource_dispatch() [Kevin]
> > - Mention in commit message that fdmon-io_uring.c is the new default [Kevin]
> > - Add comments explaining how to clean up resources in error paths [Kevin]
> > - Indicate error in return value from function with Error *errp arg [Kevin]
> > - Add patch to unindent fdmon_io_uring_destroy() [Kevin]
> > - Add patch to introduce FDMonOps->dispatch() callback [Kevin]
> > - Drop patch with hacky BH optimization for fdmon-io_uring.c [Kevin]
> > - Replace cqe_handler_bh with FDMonOps->dispatch() [Kevin]
> > - Rename AioHandler->cqe_handler field to ->internal_cqe_handler [Kevin]
> > - Consolidate fdmon-io_uring.c trace-events changes into this commit
> > - Reduce #ifdef HAVE_IO_URING_PREP_WRITEV2 code duplication [Kevin]
>
> Actually the whole last patch that contained the duplication seems to be
> missing. Did you accidentally remove it?
Yes. I'll resend in a few moments.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2025-10-30 15:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 20:33 [PATCH v5 00/12] aio: add the aio_add_sqe() io_uring API Stefan Hajnoczi
2025-10-29 20:34 ` [PATCH v5 01/12] aio-posix: fix race between io_uring CQE and AioHandler deletion Stefan Hajnoczi
2025-10-29 20:34 ` [PATCH v5 02/12] aio-posix: keep polling enabled with fdmon-io_uring.c Stefan Hajnoczi
2025-10-29 20:34 ` [PATCH v5 03/12] tests/unit: skip test-nested-aio-poll with io_uring Stefan Hajnoczi
2025-10-29 20:34 ` [PATCH v5 04/12] aio-posix: integrate fdmon into glib event loop Stefan Hajnoczi
2025-10-29 20:34 ` [PATCH v5 05/12] aio: remove aio_context_use_g_source() Stefan Hajnoczi
2025-10-29 20:34 ` [PATCH v5 06/12] aio: free AioContext when aio_context_new() fails Stefan Hajnoczi
2025-10-29 20:34 ` [PATCH v5 07/12] aio: add errp argument to aio_context_setup() Stefan Hajnoczi
2025-10-29 20:34 ` [PATCH v5 08/12] aio-posix: gracefully handle io_uring_queue_init() failure Stefan Hajnoczi
2025-10-29 20:34 ` [PATCH v5 09/12] aio-posix: unindent fdmon_io_uring_destroy() Stefan Hajnoczi
2025-10-29 20:34 ` [PATCH v5 10/12] aio-posix: add fdmon_ops->dispatch() Stefan Hajnoczi
2025-10-29 20:34 ` [PATCH v5 11/12] aio-posix: add aio_add_sqe() API for user-defined io_uring requests Stefan Hajnoczi
2025-10-29 20:34 ` [PATCH v5 12/12] block/io_uring: use aio_add_sqe() Stefan Hajnoczi
2025-10-30 14:43 ` [PATCH v5 00/12] aio: add the aio_add_sqe() io_uring API Kevin Wolf
2025-10-30 15:15 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251030151543.GA462334@fedora \
--to=stefanha@redhat.com \
--cc=eblake@redhat.com \
--cc=hibriansong@gmail.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.