From: Jakub Kicinski <kuba@kernel.org>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: Wang Liang <wangliang74@huawei.com>,
andrew@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, shuah@kernel.org, horms@kernel.org,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, yuehaibing@huawei.com,
zhangchangzhong@huawei.com
Subject: Re: [PATCH net] selftests: netdevsim: Fix ethtool-features.sh fail
Date: Thu, 30 Oct 2025 17:02:17 -0700 [thread overview]
Message-ID: <20251030170217.43e544ad@kernel.org> (raw)
In-Reply-To: <aQPxN5lQui5j8nK8@krikkit>
On Fri, 31 Oct 2025 00:13:59 +0100 Sabrina Dubroca wrote:
> > set -o pipefail
> >
> > +if ! ethtool --json -k $NSIM_NETDEV > /dev/null 2>&1; then
>
> I guess it's improving the situation, but I've got a system with an
> ethtool that accepts the --json argument, but silently ignores it for
> -k (ie `ethtool --json -k $DEV` succeeds but doesn't produce a json
> output), which will still cause the test to fail later.
And --json was added to -k in Jan 2022, that's pretty long ago.
I'm not sure we need this aspect of the patch at all..
--
pw-bot: cr
next prev parent reply other threads:[~2025-10-31 0:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 3:22 [PATCH net] selftests: netdevsim: Fix ethtool-features.sh fail Wang Liang
2025-10-30 23:13 ` Sabrina Dubroca
2025-10-31 0:02 ` Jakub Kicinski [this message]
2025-11-03 10:13 ` Sabrina Dubroca
2025-11-03 13:36 ` Andrew Lunn
2025-11-03 15:01 ` Sabrina Dubroca
2025-11-03 15:31 ` Andrew Lunn
2025-11-04 0:01 ` Jakub Kicinski
2025-11-04 11:04 ` Sabrina Dubroca
2025-11-05 0:51 ` Jakub Kicinski
2025-11-03 8:58 ` Wang Liang
2025-11-03 9:59 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251030170217.43e544ad@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=shuah@kernel.org \
--cc=wangliang74@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.