From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 852132F12CA for ; Thu, 30 Oct 2025 16:54:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761843272; cv=none; b=ARNjb3DRp4FUhGJH+x0/D6oncvfVLu3pRTlTTKl7syly0jMgGDcwJosSfPZ/Y54BUyMGNEEjWMjB0juA3YOmMpBUhoylne60HKm/TJwodwdz+ax3emv3gSJfBXXIBnJLVQMAb+ImIMUtNtuWHlbrmb579aFfHAAPkqiuu1toTyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761843272; c=relaxed/simple; bh=rF03+GwpMl44ey0Brde5kHM2GSjwJ0hgpXAsDhZoMSY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=euPxKhRK1tfqUlyA8cwQHzSDLt3uLjeKPZOkiRXjV1Xh+pyr2JIkeZZ0K/jmvH0IrkTHEVuzDF3D9a10/lt6v7YNLCzLIwo25qrsD1rGhmrwEJBCVI0zwtUXxvRjPyeUy0vY+8+PnQVdEwV/6cwSkBzpVqOd3xGrPTY8KTWWHmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=e9CTqYa+; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="e9CTqYa+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761843270; x=1793379270; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rF03+GwpMl44ey0Brde5kHM2GSjwJ0hgpXAsDhZoMSY=; b=e9CTqYa+fDK7RhlGLZY115e1JgaUvnCcNyQthqXoQPuQiRl4V9CqyWPR uB0cmigRQrUaV1RyQ/7D1vaLdDumgXni2/exC5y4ZCVRAbCh5t/KW3xC+ sWkuClqo5VCGvzMHMwSp8PUokIsvnmfMjt4MQvjLyoIKYpVuZJdn6yM+K H1TKXASzwFlEAPUXA11smwNQr1TL72nzxOCovB/p0ShXP49BdBK5yeIGT pM22RbwGSwbaPCHdpsCuYv2Me4Np7H28jcq38p5QFdT51nxgenuYm3R+g sY0pncmy9glkAV3D/s9H4bHmkLNR2aJXruJj24c0PEbPfm8ycsqXfx2hq A==; X-CSE-ConnectionGUID: o+wDqnggQsGdDB6jp2OdjA== X-CSE-MsgGUID: gs1UoUOrTGy280CrJeXcyw== X-IronPort-AV: E=McAfee;i="6800,10657,11598"; a="74592032" X-IronPort-AV: E=Sophos;i="6.19,267,1754982000"; d="scan'208";a="74592032" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2025 09:54:29 -0700 X-CSE-ConnectionGUID: eTxKsXyWRs+leMdtSd4ufA== X-CSE-MsgGUID: OjbVBkcbT3yd27RZqNyXFA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,267,1754982000"; d="scan'208";a="216663902" Received: from lkp-server02.sh.intel.com (HELO 66d7546c76b2) ([10.239.97.151]) by orviesa002.jf.intel.com with ESMTP; 30 Oct 2025 09:54:28 -0700 Received: from kbuild by 66d7546c76b2 with local (Exim 4.96) (envelope-from ) id 1vEVus-000MFc-0n; Thu, 30 Oct 2025 16:54:26 +0000 Date: Fri, 31 Oct 2025 00:53:45 +0800 From: kernel test robot To: Stefan Metzmacher Cc: oe-kbuild-all@lists.linux.dev Subject: Re: [PATCH v2 091/127] smb: client: make use of smbdirect.ko Message-ID: <202510310041.aHdeoLHq-lkp@intel.com> References: <8ae722e2bc80de69e330baa49102011572eb100b.1761742839.git.metze@samba.org> Precedence: bulk X-Mailing-List: oe-kbuild-all@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ae722e2bc80de69e330baa49102011572eb100b.1761742839.git.metze@samba.org> Hi Stefan, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.18-rc3 next-20251030] [cannot apply to cifs/for-next brauner-vfs/vfs.all v6.18-rc3 v6.18-rc2 v6.18-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Stefan-Metzmacher/smb-smbdirect-let-smbdirect-h-include-include-linux-types-h/20251030-015100 base: linus/master patch link: https://lore.kernel.org/r/8ae722e2bc80de69e330baa49102011572eb100b.1761742839.git.metze%40samba.org patch subject: [PATCH v2 091/127] smb: client: make use of smbdirect.ko config: sparc-randconfig-001-20251030 (https://download.01.org/0day-ci/archive/20251031/202510310041.aHdeoLHq-lkp@intel.com/config) compiler: sparc-linux-gcc (GCC) 8.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251031/202510310041.aHdeoLHq-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202510310041.aHdeoLHq-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from fs/smb/common/smbdirect/smbdirect_internal.h:17, from fs/smb/common/smbdirect/smbdirect_connection.c:7: fs/smb/common/smbdirect/smbdirect_socket.h:191:4: error: unknown type name 'mempool_t' mempool_t *pool; ^~~~~~~~~ fs/smb/common/smbdirect/smbdirect_socket.h:246:4: error: unknown type name 'mempool_t' mempool_t *pool; ^~~~~~~~~ fs/smb/common/smbdirect/smbdirect_connection.c: In function 'smbdirect_connection_create_mem_pools': fs/smb/common/smbdirect/smbdirect_connection.c:702:25: error: implicit declaration of function 'mempool_create_slab_pool'; did you mean 'proc_create_seq_data'? [-Werror=implicit-function-declaration] sc->send_io.mem.pool = mempool_create_slab_pool(sp->send_credit_target, ^~~~~~~~~~~~~~~~~~~~~~~~ proc_create_seq_data >> fs/smb/common/smbdirect/smbdirect_connection.c:702:23: warning: assignment to 'int *' from 'int' makes pointer from integer without a cast [-Wint-conversion] sc->send_io.mem.pool = mempool_create_slab_pool(sp->send_credit_target, ^ fs/smb/common/smbdirect/smbdirect_connection.c:731:23: warning: assignment to 'int *' from 'int' makes pointer from integer without a cast [-Wint-conversion] sc->recv_io.mem.pool = mempool_create_slab_pool(sp->recv_credit_max, ^ fs/smb/common/smbdirect/smbdirect_connection.c:739:13: error: implicit declaration of function 'mempool_alloc'; did you mean 'mm_alloc'? [-Werror=implicit-function-declaration] recv_io = mempool_alloc(sc->recv_io.mem.pool, ^~~~~~~~~~~~~ mm_alloc >> fs/smb/common/smbdirect/smbdirect_connection.c:739:11: warning: assignment to 'struct smbdirect_recv_io *' from 'int' makes pointer from integer without a cast [-Wint-conversion] recv_io = mempool_alloc(sc->recv_io.mem.pool, ^ fs/smb/common/smbdirect/smbdirect_connection.c: In function 'smbdirect_connection_destroy_mem_pools': fs/smb/common/smbdirect/smbdirect_connection.c:761:3: error: implicit declaration of function 'mempool_free'; did you mean 'reqsk_free'? [-Werror=implicit-function-declaration] mempool_free(recv_io, sc->recv_io.mem.pool); ^~~~~~~~~~~~ reqsk_free fs/smb/common/smbdirect/smbdirect_connection.c:769:2: error: implicit declaration of function 'mempool_destroy'; did you mean 'ib_mr_pool_destroy'? [-Werror=implicit-function-declaration] mempool_destroy(sc->recv_io.mem.pool); ^~~~~~~~~~~~~~~ ib_mr_pool_destroy fs/smb/common/smbdirect/smbdirect_connection.c: In function 'smbdirect_connection_alloc_send_io': >> fs/smb/common/smbdirect/smbdirect_connection.c:787:6: warning: assignment to 'struct smbdirect_send_io *' from 'int' makes pointer from integer without a cast [-Wint-conversion] msg = mempool_alloc(sc->send_io.mem.pool, sc->send_io.mem.gfp_mask); ^ cc1: some warnings being treated as errors vim +702 fs/smb/common/smbdirect/smbdirect_connection.c 2a871f3e3b060f Stefan Metzmacher 2025-10-29 675 bccbc80eff881a Stefan Metzmacher 2025-10-29 676 __SMBDIRECT_PRIVATE__ bccbc80eff881a Stefan Metzmacher 2025-10-29 677 int smbdirect_connection_create_mem_pools(struct smbdirect_socket *sc) 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 678 { 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 679 struct smbdirect_socket_parameters *sp = &sc->parameters; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 680 char name[80]; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 681 size_t i; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 682 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 683 /* 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 684 * We use sizeof(struct smbdirect_negotiate_resp) for the 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 685 * payload size as it is larger as 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 686 * sizeof(struct smbdirect_data_transfer). 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 687 * 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 688 * This will fit client and server usage for now. 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 689 */ 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 690 snprintf(name, sizeof(name), "smbdirect_send_io_cache_%p", sc); 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 691 struct kmem_cache_args send_io_args = { 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 692 .align = __alignof__(struct smbdirect_send_io), 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 693 }; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 694 sc->send_io.mem.cache = kmem_cache_create(name, 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 695 sizeof(struct smbdirect_send_io) + 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 696 sizeof(struct smbdirect_negotiate_resp), 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 697 &send_io_args, 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 698 SLAB_HWCACHE_ALIGN); 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 699 if (!sc->send_io.mem.cache) 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 700 goto err; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 701 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 @702 sc->send_io.mem.pool = mempool_create_slab_pool(sp->send_credit_target, 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 703 sc->send_io.mem.cache); 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 704 if (!sc->send_io.mem.pool) 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 705 goto err; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 706 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 707 /* 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 708 * A payload size of sp->max_recv_size should fit 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 709 * any message. 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 710 * 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 711 * For smbdirect_data_transfer messages the whole 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 712 * buffer might be exposed to userspace 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 713 * (currently on the client side...) 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 714 * The documentation says data_offset = 0 would be 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 715 * strange but valid. 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 716 */ 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 717 snprintf(name, sizeof(name), "smbdirect_recv_io_cache_%p", sc); 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 718 struct kmem_cache_args recv_io_args = { 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 719 .align = __alignof__(struct smbdirect_recv_io), 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 720 .useroffset = sizeof(struct smbdirect_recv_io), 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 721 .usersize = sp->max_recv_size, 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 722 }; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 723 sc->recv_io.mem.cache = kmem_cache_create(name, 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 724 sizeof(struct smbdirect_recv_io) + 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 725 sp->max_recv_size, 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 726 &recv_io_args, 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 727 SLAB_HWCACHE_ALIGN); 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 728 if (!sc->recv_io.mem.cache) 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 729 goto err; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 730 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 731 sc->recv_io.mem.pool = mempool_create_slab_pool(sp->recv_credit_max, 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 732 sc->recv_io.mem.cache); 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 733 if (!sc->recv_io.mem.pool) 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 734 goto err; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 735 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 736 for (i = 0; i < sp->recv_credit_max; i++) { 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 737 struct smbdirect_recv_io *recv_io; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 738 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 @739 recv_io = mempool_alloc(sc->recv_io.mem.pool, 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 740 sc->recv_io.mem.gfp_mask); 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 741 if (!recv_io) 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 742 goto err; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 743 recv_io->socket = sc; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 744 recv_io->sge.length = 0; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 745 list_add_tail(&recv_io->list, &sc->recv_io.free.list); 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 746 } 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 747 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 748 return 0; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 749 err: 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 750 smbdirect_connection_destroy_mem_pools(sc); 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 751 return -ENOMEM; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 752 } 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 753 bccbc80eff881a Stefan Metzmacher 2025-10-29 754 __SMBDIRECT_PRIVATE__ bccbc80eff881a Stefan Metzmacher 2025-10-29 755 void smbdirect_connection_destroy_mem_pools(struct smbdirect_socket *sc) 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 756 { 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 757 struct smbdirect_recv_io *recv_io, *next_io; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 758 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 759 list_for_each_entry_safe(recv_io, next_io, &sc->recv_io.free.list, list) { 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 760 list_del(&recv_io->list); 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 761 mempool_free(recv_io, sc->recv_io.mem.pool); 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 762 } 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 763 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 764 /* 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 765 * Note mempool_destroy() and kmem_cache_destroy() 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 766 * work fine with a NULL pointer 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 767 */ 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 768 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 769 mempool_destroy(sc->recv_io.mem.pool); 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 770 sc->recv_io.mem.pool = NULL; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 771 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 772 kmem_cache_destroy(sc->recv_io.mem.cache); 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 773 sc->recv_io.mem.cache = NULL; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 774 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 775 mempool_destroy(sc->send_io.mem.pool); 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 776 sc->send_io.mem.pool = NULL; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 777 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 778 kmem_cache_destroy(sc->send_io.mem.cache); 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 779 sc->send_io.mem.cache = NULL; 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 780 } 632cc85ae7ad30 Stefan Metzmacher 2025-10-29 781 bccbc80eff881a Stefan Metzmacher 2025-10-29 782 __SMBDIRECT_PRIVATE__ bccbc80eff881a Stefan Metzmacher 2025-10-29 783 struct smbdirect_send_io *smbdirect_connection_alloc_send_io(struct smbdirect_socket *sc) 146a52bb357ea7 Stefan Metzmacher 2025-10-29 784 { 146a52bb357ea7 Stefan Metzmacher 2025-10-29 785 struct smbdirect_send_io *msg; 146a52bb357ea7 Stefan Metzmacher 2025-10-29 786 146a52bb357ea7 Stefan Metzmacher 2025-10-29 @787 msg = mempool_alloc(sc->send_io.mem.pool, sc->send_io.mem.gfp_mask); 146a52bb357ea7 Stefan Metzmacher 2025-10-29 788 if (!msg) 146a52bb357ea7 Stefan Metzmacher 2025-10-29 789 return ERR_PTR(-ENOMEM); 146a52bb357ea7 Stefan Metzmacher 2025-10-29 790 msg->socket = sc; 146a52bb357ea7 Stefan Metzmacher 2025-10-29 791 INIT_LIST_HEAD(&msg->sibling_list); 146a52bb357ea7 Stefan Metzmacher 2025-10-29 792 msg->num_sge = 0; 146a52bb357ea7 Stefan Metzmacher 2025-10-29 793 146a52bb357ea7 Stefan Metzmacher 2025-10-29 794 return msg; 146a52bb357ea7 Stefan Metzmacher 2025-10-29 795 } 146a52bb357ea7 Stefan Metzmacher 2025-10-29 796 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki