From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,pmladek@suse.com,feng.tang@linux.alibaba.com,andriy.shevchenko@linux.intel.com,akpm@linux-foundation.org
Subject: + panic-sys_info-deduplicate-local-variable-table-assignments.patch added to mm-nonmm-unstable branch
Date: Thu, 30 Oct 2025 20:12:58 -0700 [thread overview]
Message-ID: <20251031031259.1E71EC113D0@smtp.kernel.org> (raw)
The patch titled
Subject: panic: sys_info: deduplicate local variable 'table; assignments
has been added to the -mm mm-nonmm-unstable branch. Its filename is
panic-sys_info-deduplicate-local-variable-table-assignments.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/panic-sys_info-deduplicate-local-variable-table-assignments.patch
This patch will later appear in the mm-nonmm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: panic: sys_info: deduplicate local variable 'table; assignments
Date: Thu, 30 Oct 2025 12:44:21 +0100
The both handlers use the local 'table' variable and assign the same data
to it, deduplicate that.
Link: https://lkml.kernel.org/r/20251030132007.3742368-6-andriy.shevchenko@linux.intel.com
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Feng Tang <feng.tang@linux.alibaba.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/sys_info.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
--- a/lib/sys_info.c~panic-sys_info-deduplicate-local-variable-table-assignments
+++ a/lib/sys_info.c
@@ -63,12 +63,13 @@ int sysctl_sys_info_handler(const struct
if (!names)
return -ENOMEM;
+ table = *ro_table;
+ table.data = names;
+ table.maxlen = maxlen;
+
if (write) {
int ret;
- table = *ro_table;
- table.data = names;
- table.maxlen = maxlen;
ret = proc_dostring(&table, write, buffer, lenp, ppos);
if (ret)
return ret;
@@ -93,9 +94,6 @@ int sysctl_sys_info_handler(const struct
}
}
- table = *ro_table;
- table.data = names;
- table.maxlen = maxlen;
return proc_dostring(&table, write, buffer, lenp, ppos);
}
}
_
Patches currently in -mm which might be from andriy.shevchenko@linux.intel.com are
panic-sys_info-capture-si_bits_global-before-iterating-over-it.patch
panic-sys_info-align-constant-definition-names-with-parameters.patch
panic-sys_info-replace-struct-sys_info_name-with-plain-array-of-strings.patch
panic-sys_info-rewrite-a-fix-for-a-compilation-error-make-w=1.patch
panic-sys_info-deduplicate-local-variable-table-assignments.patch
panic-sys_info-factor-out-read-and-write-handlers.patch
reply other threads:[~2025-10-31 3:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031031259.1E71EC113D0@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=feng.tang@linux.alibaba.com \
--cc=mm-commits@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.