From: Greg KH <gregkh@linuxfoundation.org>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
jirislaby@kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>
Subject: Re: [PATCH v3 11/14] serial: sc16is7xx: use KBUILD_MODNAME
Date: Fri, 31 Oct 2025 08:06:21 +0100 [thread overview]
Message-ID: <2025103109-astronaut-oblivious-ad13@gregkh> (raw)
In-Reply-To: <20251030160142.e1ae7b158216b8101582cd49@hugovil.com>
On Thu, Oct 30, 2025 at 04:01:42PM -0400, Hugo Villeneuve wrote:
> On Thu, 30 Oct 2025 11:35:00 +0100
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
>
> > On Mon, Oct 27, 2025 at 10:29:53AM -0400, Hugo Villeneuve wrote:
> > >
> > > There is no need to redefine the driver name. Use KBUILD_MODNAME and get
> > > rid of DRV_NAME altogether.
> >
> > Actually I am slightly against this change. The modname (and hence modalias)
> > are parts of an ABI (visible via sysfs). Changing the module name (file name
> > in this case) may inadvertently break this. Yes, it most likely not critical
> > in this case, but should be taken into account.
>
> Hi Andy,
> thank you for pointing that out. It didn't occur to me that this could
> impact the sysfs ABI.
This should not be an issue, the device name will not have changed, and
that's the normal sysfs path for things. The module/driver name can
always change, this isn't a real problem.
thanks,
greg k-h
next prev parent reply other threads:[~2025-10-31 7:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 14:29 [PATCH v3 00/14] serial: sc16is7xx: register access fixes and improvements Hugo Villeneuve
2025-10-27 14:29 ` [PATCH v3 01/14] serial: sc16is7xx: rename LCR macros to better reflect usage Hugo Villeneuve
2025-10-27 14:29 ` [PATCH v3 02/14] serial: sc16is7xx: rename EFR mutex with generic name Hugo Villeneuve
2025-10-27 14:29 ` [PATCH v3 03/14] serial: sc16is7xx: define common register access function Hugo Villeneuve
2025-10-27 14:29 ` [PATCH v3 04/14] serial: sc16is7xx: remove unnecessary pointer cast Hugo Villeneuve
2025-10-27 14:29 ` [PATCH v3 05/14] serial: sc16is7xx: use guards for simple mutex locks Hugo Villeneuve
2025-10-27 14:29 ` [PATCH v3 06/14] serial: sc16is7xx: drop -ENOMEM error message Hugo Villeneuve
2025-10-27 14:29 ` [PATCH v3 07/14] serial: sc16is7xx: declare SPR/TLR/XOFF2 register as volatile Hugo Villeneuve
2025-10-27 14:29 ` [PATCH v3 08/14] serial: sc16is7xx: move port/channel init to separate function Hugo Villeneuve
2025-10-27 14:29 ` [PATCH v3 09/14] serial: sc16is7xx: simplify to_sc16is7xx_one() with a single parameter Hugo Villeneuve
2025-10-27 14:29 ` [PATCH v3 10/14] serial: sc16is7xx: Kconfig: allow building with COMPILE_TEST Hugo Villeneuve
2025-10-27 14:29 ` [PATCH v3 11/14] serial: sc16is7xx: use KBUILD_MODNAME Hugo Villeneuve
2025-10-30 10:35 ` Andy Shevchenko
2025-10-30 20:01 ` Hugo Villeneuve
2025-10-31 7:06 ` Greg KH [this message]
2025-10-27 14:29 ` [PATCH v3 12/14] serial: sc16is7xx: change conditional operator indentation Hugo Villeneuve
2025-10-27 14:29 ` [PATCH v3 13/14] serial: sc16is7xx: reformat comments to improve readability Hugo Villeneuve
2025-10-27 14:29 ` [PATCH v3 14/14] serial: sc16is7xx: add comments for lock requirements Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025103109-astronaut-oblivious-ad13@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.