From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH] crypto/hash: Have hashing functions take void * buffer argument
Date: Fri, 31 Oct 2025 10:09:30 +0100 [thread overview]
Message-ID: <20251031090930.27159-1-philmd@linaro.org> (raw)
Cryptographic hash function can operate on any area of memory,
regardless of the content their represent. Do not restrict to
array of char, use the void* type, which is also the type of
the underlying iovec::iov_base field.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/crypto/hash.h | 8 ++++----
include/crypto/hmac.h | 4 ++--
crypto/hash.c | 16 ++++++++--------
crypto/hmac.c | 8 ++++----
4 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/include/crypto/hash.h b/include/crypto/hash.h
index 1868d4a0f78..43525098c51 100644
--- a/include/crypto/hash.h
+++ b/include/crypto/hash.h
@@ -122,7 +122,7 @@ int qcrypto_hash_bytesv(QCryptoHashAlgo alg,
* Returns: 0 on success, -1 on error
*/
int qcrypto_hash_bytes(QCryptoHashAlgo alg,
- const char *buf,
+ const void *buf,
size_t len,
uint8_t **result,
size_t *resultlen,
@@ -180,7 +180,7 @@ int qcrypto_hash_updatev(QCryptoHash *hash,
* Returns: 0 on success, -1 on error
*/
int qcrypto_hash_update(QCryptoHash *hash,
- const char *buf,
+ const void *buf,
size_t len,
Error **errp);
@@ -289,7 +289,7 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(QCryptoHash, qcrypto_hash_free)
* Returns: 0 on success, -1 on error
*/
int qcrypto_hash_digest(QCryptoHashAlgo alg,
- const char *buf,
+ const void *buf,
size_t len,
char **digest,
Error **errp);
@@ -335,7 +335,7 @@ int qcrypto_hash_base64v(QCryptoHashAlgo alg,
* Returns: 0 on success, -1 on error
*/
int qcrypto_hash_base64(QCryptoHashAlgo alg,
- const char *buf,
+ const void *buf,
size_t len,
char **base64,
Error **errp);
diff --git a/include/crypto/hmac.h b/include/crypto/hmac.h
index af3d5f8feb2..0885ae22d1d 100644
--- a/include/crypto/hmac.h
+++ b/include/crypto/hmac.h
@@ -139,7 +139,7 @@ int qcrypto_hmac_bytesv(QCryptoHmac *hmac,
* 0 on success, -1 on error
*/
int qcrypto_hmac_bytes(QCryptoHmac *hmac,
- const char *buf,
+ const void *buf,
size_t len,
uint8_t **result,
size_t *resultlen,
@@ -187,7 +187,7 @@ int qcrypto_hmac_digestv(QCryptoHmac *hmac,
* Returns: 0 on success, -1 on error
*/
int qcrypto_hmac_digest(QCryptoHmac *hmac,
- const char *buf,
+ const void *buf,
size_t len,
char **digest,
Error **errp);
diff --git a/crypto/hash.c b/crypto/hash.c
index 7513769e42d..6ffb88bf541 100644
--- a/crypto/hash.c
+++ b/crypto/hash.c
@@ -67,13 +67,13 @@ int qcrypto_hash_bytesv(QCryptoHashAlgo alg,
int qcrypto_hash_bytes(QCryptoHashAlgo alg,
- const char *buf,
+ const void *buf,
size_t len,
uint8_t **result,
size_t *resultlen,
Error **errp)
{
- struct iovec iov = { .iov_base = (char *)buf,
+ struct iovec iov = { .iov_base = (void *)buf,
.iov_len = len };
return qcrypto_hash_bytesv(alg, &iov, 1, result, resultlen, errp);
}
@@ -89,11 +89,11 @@ int qcrypto_hash_updatev(QCryptoHash *hash,
}
int qcrypto_hash_update(QCryptoHash *hash,
- const char *buf,
+ const void *buf,
size_t len,
Error **errp)
{
- struct iovec iov = { .iov_base = (char *)buf, .iov_len = len };
+ struct iovec iov = { .iov_base = (void *)buf, .iov_len = len };
return qcrypto_hash_updatev(hash, &iov, 1, errp);
}
@@ -206,12 +206,12 @@ int qcrypto_hash_digestv(QCryptoHashAlgo alg,
}
int qcrypto_hash_digest(QCryptoHashAlgo alg,
- const char *buf,
+ const void *buf,
size_t len,
char **digest,
Error **errp)
{
- struct iovec iov = { .iov_base = (char *)buf, .iov_len = len };
+ struct iovec iov = { .iov_base = (void *)buf, .iov_len = len };
return qcrypto_hash_digestv(alg, &iov, 1, digest, errp);
}
@@ -237,12 +237,12 @@ int qcrypto_hash_base64v(QCryptoHashAlgo alg,
}
int qcrypto_hash_base64(QCryptoHashAlgo alg,
- const char *buf,
+ const void *buf,
size_t len,
char **base64,
Error **errp)
{
- struct iovec iov = { .iov_base = (char *)buf, .iov_len = len };
+ struct iovec iov = { .iov_base = (void *)buf, .iov_len = len };
return qcrypto_hash_base64v(alg, &iov, 1, base64, errp);
}
diff --git a/crypto/hmac.c b/crypto/hmac.c
index 422e005182a..2f0d044cf27 100644
--- a/crypto/hmac.c
+++ b/crypto/hmac.c
@@ -28,14 +28,14 @@ int qcrypto_hmac_bytesv(QCryptoHmac *hmac,
}
int qcrypto_hmac_bytes(QCryptoHmac *hmac,
- const char *buf,
+ const void *buf,
size_t len,
uint8_t **result,
size_t *resultlen,
Error **errp)
{
struct iovec iov = {
- .iov_base = (char *)buf,
+ .iov_base = (void *)buf,
.iov_len = len
};
@@ -70,13 +70,13 @@ int qcrypto_hmac_digestv(QCryptoHmac *hmac,
}
int qcrypto_hmac_digest(QCryptoHmac *hmac,
- const char *buf,
+ const void *buf,
size_t len,
char **digest,
Error **errp)
{
struct iovec iov = {
- .iov_base = (char *)buf,
+ .iov_base = (void *)buf,
.iov_len = len
};
--
2.51.0
next reply other threads:[~2025-10-31 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 9:09 Philippe Mathieu-Daudé [this message]
2025-10-31 11:40 ` [PATCH] crypto/hash: Have hashing functions take void * buffer argument Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031090930.27159-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.