All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: "Kasireddy, Vivek" <vivek.kasireddy@intel.com>,
	"Leon Romanovsky" <leonro@nvidia.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Simona Vetter" <simona.vetter@ffwll.ch>,
	"Brost, Matthew" <matthew.brost@intel.com>,
	"Kim, Dongwon" <dongwon.kim@intel.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>
Subject: Re: [RFC v2 0/8] dma-buf: Add support for mapping dmabufs via interconnects
Date: Fri, 31 Oct 2025 10:16:25 -0300	[thread overview]
Message-ID: <20251031131625.GC1235738@nvidia.com> (raw)
In-Reply-To: <146d57e6-29dd-4412-9786-a630574e4872@amd.com>

On Fri, Oct 31, 2025 at 08:46:34AM +0100, Christian König wrote:
> On 10/31/25 06:15, Kasireddy, Vivek wrote:
> > Hi Jason,
> > 
> >> Subject: Re: [RFC v2 0/8] dma-buf: Add support for mapping dmabufs via
> >> interconnects
> >>
> >> On Thu, Oct 30, 2025 at 06:17:11AM +0000, Kasireddy, Vivek wrote:
> >>> It mostly looks OK to me but there are a few things that I want to discuss,
> >>> after briefly looking at the patches in your branch:
> >>> - I am wondering what is the benefit of the SGT compatibility stuff especially
> >>> when Christian suggested that he'd like to see SGT usage gone from
> >>> dma-buf
> >>
> >> I think to get rid of SGT we do need to put it in a little well
> >> defined box and then create alternatives and remove things using
> >> SGT. This is a long journey, and I think this is the first step.
> >>
> >> If SGT is some special case it will be harder to excise.
> >>
> >> So the next steps would be to make all the exporters directly declare
> >> a SGT and then remove the SGT related ops from dma_ops itself and
> >> remove the compat sgt in the attach logic. This is not hard, it is all
> >> simple mechanical work.
> > IMO, this SGT compatibility stuff should ideally be a separate follow-on
> > effort (and patch series) that would also probably include updates to
> > various drivers to add the SGT mapping type.
> 
> Nope, just the other way around. In other words the SGT
> compatibility is a pre-requisite.
> 
> We should first demonstrate with existing drivers that the new
> interface works and does what it promised to do and then extend it
> with new functionality.

Ok, so I think that is what my github is showing.

Everything interworks, non-mapping-type aware code simply acts exactly
as though it is using a SGT mapping type from the perspective of aware
code.

I see a fairly easy path to do some driver upgrades to make more
things more mapping aware and remove some of the compatibility parts.

Let me see if I can post a RFC version next week, got a big pile of
other stuff to do still..

Jason

  reply	other threads:[~2025-10-31 13:16 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-27  4:44 [RFC v2 0/8] dma-buf: Add support for mapping dmabufs via interconnects Vivek Kasireddy
2025-10-27  4:44 ` [RFC v2 1/8] dma-buf: Add support for map/unmap APIs for interconnects Vivek Kasireddy
2025-10-27 17:47   ` Jason Gunthorpe
2025-10-28  5:39     ` Kasireddy, Vivek
2025-10-28 12:21       ` Jason Gunthorpe
2025-10-27  4:44 ` [RFC v2 2/8] dma-buf: Add a helper to match interconnects between exporter/importer Vivek Kasireddy
2025-10-27 18:18   ` Jason Gunthorpe
2025-10-28  6:04     ` Kasireddy, Vivek
2025-10-27  4:44 ` [RFC v2 3/8] dma-buf: Create and expose IOV interconnect to all exporters/importers Vivek Kasireddy
2025-10-27  4:44 ` [RFC v2 4/8] vfio/pci/dmabuf: Add support for IOV interconnect Vivek Kasireddy
2025-10-28  2:00   ` Matthew Brost
2025-10-28  5:05     ` Kasireddy, Vivek
2025-10-27  4:44 ` [RFC v2 5/8] drm/xe/dma_buf: " Vivek Kasireddy
2025-10-27  4:44 ` [RFC v2 6/8] drm/xe/pf: Add a helper function to get a VF's backing object in LMEM Vivek Kasireddy
2025-10-27  4:44 ` [RFC v2 7/8] drm/xe/bo: Create new dma_addr array for dmabuf BOs associated with VFs Vivek Kasireddy
2025-10-27  4:44 ` [RFC v2 8/8] drm/xe/pt: Add an additional check for dmabuf BOs while doing bind Vivek Kasireddy
2025-10-29  0:27 ` [RFC v2 0/8] dma-buf: Add support for mapping dmabufs via interconnects Jason Gunthorpe
2025-10-29  9:25   ` Leon Romanovsky
2025-10-29 11:53     ` Jason Gunthorpe
2025-10-30  6:17   ` Kasireddy, Vivek
2025-10-30 13:43     ` Jason Gunthorpe
2025-10-31  5:15       ` Kasireddy, Vivek
2025-10-31  7:46         ` Christian König
2025-10-31 13:16           ` Jason Gunthorpe [this message]
2026-01-23 22:50         ` Jason Gunthorpe
2026-01-27  6:03           ` Kasireddy, Vivek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251031131625.GC1235738@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=christian.koenig@amd.com \
    --cc=dongwon.kim@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=leonro@nvidia.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-media@vger.kernel.org \
    --cc=matthew.brost@intel.com \
    --cc=simona.vetter@ffwll.ch \
    --cc=sumit.semwal@linaro.org \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=vivek.kasireddy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.