From: Christoph Hellwig <hch@lst.de>
To: alistair23@gmail.com
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
hare@suse.de, kch@nvidia.com, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH 2/3] nvmet-tcp: Don't free SQ on authentication success
Date: Fri, 31 Oct 2025 15:03:10 +0100 [thread overview]
Message-ID: <20251031140310.GA17006@lst.de> (raw)
In-Reply-To: <20251030035114.16840-3-alistair.francis@wdc.com>
On Thu, Oct 30, 2025 at 01:51:13PM +1000, alistair23@gmail.com wrote:
> Curently after the host sends a REPLACETLSPSK we free the TLS keys as
> part of calling nvmet_auth_sq_free() on success. This means when the
> host sends a follow up REPLACETLSPSK we return CONCAT_MISMATCH as the
> check for !nvmet_queue_tls_keyid(req->sq) fails.
>
> This patch ensures we don't free the TLS key on success as we might need
> it again in the future.
I initially though we'd now keep it around for the lifetime of the
queue, but I think we'll still free it from nvmet_execute_auth_send,
right?
next prev parent reply other threads:[~2025-10-31 14:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 3:51 [PATCH 0/3] nvme: Support PSK reauthentication (REPLACETLSPSK) alistair23
2025-10-30 3:51 ` [PATCH 1/3] nvmet-tcp: Don't error if TLS is enabed on a reset alistair23
2025-10-31 10:03 ` Christoph Hellwig
2025-10-30 3:51 ` [PATCH 2/3] nvmet-tcp: Don't free SQ on authentication success alistair23
2025-10-31 14:03 ` Christoph Hellwig [this message]
2025-11-03 1:40 ` Alistair Francis
2025-10-30 3:51 ` [PATCH 3/3] nvme: Allow reauth from sysfs alistair23
2025-10-31 14:05 ` Christoph Hellwig
2025-11-03 1:47 ` Alistair Francis
2025-11-03 2:05 ` Chaitanya Kulkarni
2025-11-03 2:24 ` Alistair Francis
2025-11-03 2:32 ` Chaitanya Kulkarni
2025-11-03 11:58 ` Christoph Hellwig
2025-11-03 12:08 ` Hannes Reinecke
2025-11-11 23:32 ` Alistair Francis
2025-11-12 7:02 ` Christoph Hellwig
2025-11-12 7:21 ` Hannes Reinecke
2025-11-12 8:32 ` Christoph Hellwig
2025-11-13 4:01 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031140310.GA17006@lst.de \
--to=hch@lst.de \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.