From: Jakub Kicinski <kuba@kernel.org>
To: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, longli@microsoft.com,
kotaranov@microsoft.com, horms@kernel.org,
shradhagupta@linux.microsoft.com, ssengar@linux.microsoft.com,
dipayanroy@linux.microsoft.com, shirazsaleem@microsoft.com,
rosenp@gmail.com, linux-hyperv@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net: mana: Refactor GF stats to use global mana_context
Date: Fri, 31 Oct 2025 16:06:32 -0700 [thread overview]
Message-ID: <20251031160632.41c1167f@kernel.org> (raw)
In-Reply-To: <1761734272-32055-2-git-send-email-ernis@linux.microsoft.com>
On Wed, 29 Oct 2025 03:37:51 -0700 Erni Sri Satya Vennela wrote:
> Refactor mana_query_gf_stats() to use mana_context instead of per-port,
> enabling single query for all VFs.
What does "single query for all VFs" mean?
All types? All within the host?
Coincidentally I don't know what HC and GF stand for.
Please explain things in more detail, all atypical acronyms
(for *Linux* networking).
> Isolate hardware counter stats by introducing mana_ethtool_hc_stats
> in mana_context and update the code to ensure all stats are properly
> reported via ethtool -S <interface>, maintaining consistency with
> previous behavior.
> -void mana_query_gf_stats(struct mana_port_context *apc)
> +void mana_query_gf_stats(struct mana_context *ac)
> {
> struct mana_query_gf_stat_resp resp = {};
> struct mana_query_gf_stat_req req = {};
> - struct net_device *ndev = apc->ndev;
> + struct gdma_context *gc = ac->gdma_dev->gdma_context;
reverse xmas tree, please
> + struct device *dev = gc->dev;
> int err;
next prev parent reply other threads:[~2025-10-31 23:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 10:37 [PATCH net-next v2 0/2] net: mana: Refactor GF stats handling and add rx_missed_errors counter Erni Sri Satya Vennela
2025-10-29 10:37 ` [PATCH net-next v2 1/2] net: mana: Refactor GF stats to use global mana_context Erni Sri Satya Vennela
2025-10-31 23:06 ` Jakub Kicinski [this message]
2025-11-11 4:01 ` Erni Sri Satya Vennela
2025-10-29 10:37 ` [PATCH net-next v2 2/2] net: mana: Add standard counter rx_missed_errors Erni Sri Satya Vennela
2025-10-31 23:17 ` Jakub Kicinski
2025-11-11 4:03 ` Erni Sri Satya Vennela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031160632.41c1167f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=dipayanroy@linux.microsoft.com \
--cc=edumazet@google.com \
--cc=ernis@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=horms@kernel.org \
--cc=kotaranov@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
--cc=shirazsaleem@microsoft.com \
--cc=shradhagupta@linux.microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.