From: Jakub Kicinski <kuba@kernel.org>
To: vadim.fedorenko@linux.dev
Cc: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>,
richardcochran@gmail.com, jonathan.lemon@gmail.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptp: ocp: Add newline to sysfs attribute output
Date: Fri, 31 Oct 2025 16:59:03 -0700 [thread overview]
Message-ID: <20251031165903.4b94aa66@kernel.org> (raw)
In-Reply-To: <20251030124519.1828058-1-zhongqiu.han@oss.qualcomm.com>
On Thu, 30 Oct 2025 20:45:19 +0800 Zhongqiu Han wrote:
> Append a newline character to the sysfs_emit() output in ptp_ocp_tty_show.
> This aligns with common kernel conventions and improves readability for
> userspace tools that expect newline-terminated values.
Vadim? Is the backward compat here a concern?
next prev parent reply other threads:[~2025-10-31 23:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 12:45 [PATCH] ptp: ocp: Add newline to sysfs attribute output Zhongqiu Han
2025-10-31 23:59 ` Jakub Kicinski [this message]
2025-11-01 11:18 ` Vadim Fedorenko
2025-11-01 23:45 ` Vadim Fedorenko
2025-11-03 0:00 ` Jakub Kicinski
2025-11-03 13:04 ` Zhongqiu Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031165903.4b94aa66@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jonathan.lemon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
--cc=zhongqiu.han@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.