All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Stanimir Varbanov <svarbanov@suse.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rpi-kernel@lists.infradead.org,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Andrea della Porta <andrea.porta@suse.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	Phil Elwell <phil@raspberrypi.com>,
	Jonathan Bell <jonathan@raspberrypi.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH v2 0/5] dd ethernet support for RPi5
Date: Sun, 2 Nov 2025 02:30:42 +0200	[thread overview]
Message-ID: <20251102003042.GJ797@pendragon.ideasonboard.com> (raw)
In-Reply-To: <eef9a83f-6103-4ab2-927c-921dd9a6a5b3@suse.de>

On Fri, Oct 31, 2025 at 05:35:32PM +0200, Stanimir Varbanov wrote:
> On 10/31/25 1:45 PM, Laurent Pinchart wrote:
> > On Fri, Aug 22, 2025 at 12:34:35PM +0300, Stanimir Varbanov wrote:
> >> Hello,
> >>
> >> Changes in v2:
> >>  - In 1/5 updates according to review comments (Nicolas)
> >>  - In 1/5 added Fixes tag (Nicolas)
> >>  - Added Reviewed-by and Acked-by tags.
> >>
> >> v1 can found at [1].
> >>
> >> Comments are welcome!
> > 
> > I'm very happy to see support for Raspberry Pi 5 progressing fast
> > upstream.
> > 
> > I've tested the latest mainline kernel (v6.18-rc3) that includes this
> > series (except for 1/5 that is replaced by
> > https://lore.kernel.org/all/20250820-macb-fixes-v4-0-23c399429164@bootlin.com/
> > as far as I understand). The ethernet controller is successfully
> > detected, and so is the PHY. Link status seems to work fine too, but
> > data doesn't seem to go through when the kernel tries to get a DHCP
> > address (for NFS root). Here's the end of the kernel log (with the
> > messages related to the USB controller stripped out):
> > 
> > [    0.896779] rp1_pci 0002:01:00.0: assign IRQ: got 27
> > [    0.896809] rp1_pci 0002:01:00.0: enabling device (0000 -> 0002)
> > [    0.896840] rp1_pci 0002:01:00.0: enabling bus mastering
> > [    0.931874] macb 1f00100000.ethernet: invalid hw address, using random
> > [    0.944448] macb 1f00100000.ethernet eth0: Cadence GEM rev 0x00070109 at 0x1f00100000 irq 95 (da:2e:6d:9d:52:a4)
> > [    0.989067] macb 1f00100000.ethernet eth0: PHY [1f00100000.ethernet-ffffffff:01] driver [Broadcom BCM54210E] (irq=POLL)
> > [    0.989272] macb 1f00100000.ethernet eth0: configuring for phy/rgmii-id link mode
> > [    0.991271] macb 1f00100000.ethernet: gem-ptp-timer ptp clock registered.
> > [    4.039490] macb 1f00100000.ethernet eth0: Link is Up - 1Gbps/Full - flow control tx
> > [    4.062589] Sending DHCP requests .....
> > [   40.902771] macb 1f00100000.ethernet eth0: Link is Down
> > [   43.975334] macb 1f00100000.ethernet eth0: Link is Up - 1Gbps/Full - flow control tx
> > 
> > I've tried porting patches to drivers/net/phy/broadcom.c from the
> > Raspberry Pi kernel to specifically support the BCM54213PE PHY (which is
> > otherwise identified as a BCM54210E), but they didn't seem to help.
> > 
> > What's the status of ethernet support on the Pi 5, is it supposed to
> > work upstream, or are there pieces still missing ?
> 
> We have this [1] patch queued up, could you give it a try please.
> 
> [1] https://www.spinics.net/lists/kernel/msg5889475.html

It fixes the issue, thank you ! I've sent a patch to add an ethernet0
alias (https://lore.kernel.org/all/20251102002901.467-1-laurent.pinchart@ideasonboard.com),
with that I get working ethernet with a stable MAC address.

-- 
Regards,

Laurent Pinchart


      reply	other threads:[~2025-11-02  0:31 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22  9:34 [PATCH v2 0/5] dd ethernet support for RPi5 Stanimir Varbanov
2025-08-22  9:34 ` [PATCH v2 1/5] net: cadence: macb: Set upper 32bits of DMA ring buffer Stanimir Varbanov
2025-08-22  9:42   ` Nicolas Ferre
2025-08-22 15:16   ` Claudiu Beznea
2025-08-25 23:53   ` Jakub Kicinski
2025-08-26  8:35     ` Stanimir Varbanov
2025-08-26  9:13       ` Nicolas Ferre
2025-08-28  8:29         ` Stanimir Varbanov
2025-08-26  9:14     ` Nicolas Ferre
2025-08-28  8:29       ` Stanimir Varbanov
2025-09-10 16:57       ` Théo Lebrun
2025-09-11  7:21         ` Théo Lebrun
2025-08-22  9:34 ` [PATCH v2 2/5] dt-bindings: net: cdns,macb: Add compatible for Raspberry Pi RP1 Stanimir Varbanov
2025-08-22 12:15   ` Nicolas Ferre
2025-08-22 15:17   ` Claudiu Beznea
2025-08-22  9:34 ` [PATCH v2 3/5] net: cadence: macb: Add support for Raspberry Pi RP1 ethernet controller Stanimir Varbanov
2025-08-22 12:13   ` Nicolas Ferre
2025-08-22 15:17   ` Claudiu Beznea
2025-09-10 11:32   ` Stanimir Varbanov
2025-09-15 11:27     ` Stanimir Varbanov
2025-09-15 13:34       ` Andrew Lunn
2025-09-15 14:31         ` Stanimir Varbanov
2025-08-22  9:34 ` [PATCH v2 4/5] arm64: dts: rp1: Add ethernet DT node Stanimir Varbanov
2025-09-04 21:06   ` Florian Fainelli
2025-08-22  9:34 ` [PATCH v2 5/5] arm64: dts: broadcom: Enable RP1 ethernet for Raspberry Pi 5 Stanimir Varbanov
2025-09-04 21:06   ` Florian Fainelli
2025-09-04 21:07 ` [PATCH v2 0/5] dd ethernet support for RPi5 Florian Fainelli
2025-09-05  1:47   ` Jakub Kicinski
2025-09-05  1:49     ` Jakub Kicinski
2025-09-05 11:43       ` Stanimir Varbanov
2025-09-05  2:00 ` patchwork-bot+netdevbpf
2025-10-31 11:45 ` Laurent Pinchart
2025-10-31 15:35   ` Stanimir Varbanov
2025-11-02  0:30     ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251102003042.GJ797@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=andrea.porta@suse.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=conor+dt@kernel.org \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=jonathan@raspberrypi.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=pabeni@redhat.com \
    --cc=phil@raspberrypi.com \
    --cc=robh@kernel.org \
    --cc=svarbanov@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.