From: Chaitanya Kulkarni <ckulkarnilinux@gmail.com>
To: hare@suse.de, kbusch@kernel.org
Cc: hch@lst.de, linux-nvme@lists.infradead.org,
Chaitanya Kulkarni <ckulkarnilinux@gmail.com>,
kernel test robot <lkp@intel.com>
Subject: [PATCH] nvme-keyring: mark nvme_dhchap_psk_hash() as static inline
Date: Sat, 1 Nov 2025 20:17:01 -0700 [thread overview]
Message-ID: <20251102031701.69920-1-ckulkarnilinux@gmail.com> (raw)
Fix build warning when CONFIG_NVME_KEYRING is not enabled:
include/linux/nvme-keyring.h:57:4: warning: no previous prototype for
function 'nvme_dhchap_psk_hash' [-Wmissing-prototypes]
The nvme_dhchap_psk_hash() stub function in the #else block is missing
the 'static inline' qualifiers that all other stub functions in the same
block have. Add them to fix the warning.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202511011103.e6eXLAln-lkp@intel.com/
Fixes: 8d9937531a4d ("nvme-keyring: add 'dhchap' key type")
Signed-off-by: Chaitanya Kulkarni <ckulkarnilinux@gmail.com>
---
include/linux/nvme-keyring.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/nvme-keyring.h b/include/linux/nvme-keyring.h
index 6115bf5cf346..4bdac22b3cbb 100644
--- a/include/linux/nvme-keyring.h
+++ b/include/linux/nvme-keyring.h
@@ -54,7 +54,7 @@ static inline struct key *nvme_dhchap_psk_lookup(struct key *keyring,
{
return ERR_PTR(-ENOTSUPP);
}
-u8 nvme_dhchap_psk_hash(struct key *key)
+static inline u8 nvme_dhchap_psk_hash(struct key *key)
{
return 0;
}
--
2.40.0
next reply other threads:[~2025-11-02 3:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-02 3:17 Chaitanya Kulkarni [this message]
2025-11-03 11:46 ` [PATCH] nvme-keyring: mark nvme_dhchap_psk_hash() as static inline Christoph Hellwig
2025-11-03 15:35 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251102031701.69920-1-ckulkarnilinux@gmail.com \
--to=ckulkarnilinux@gmail.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.