From: Oleg Nesterov <oleg@redhat.com>
To: Christian Brauner <brauner@kernel.org>
Cc: linux-fsdevel@vger.kernel.org,
"Amir Goldstein" <amir73il@gmail.com>,
"Aleksa Sarai" <cyphar@cyphar.com>,
"Yu Watanabe" <watanabe.yu+github@gmail.com>,
"Josef Bacik" <josef@toxicpanda.com>,
"Jeff Layton" <jlayton@kernel.org>,
"Jann Horn" <jannh@google.com>,
"Luca Boccassi" <luca.boccassi@gmail.com>,
"Alexander Mikhalitsyn" <alexander@mihalicyn.com>,
linux-kernel@vger.kernel.org,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Jan Kara" <jack@suse.cz>,
"Lennart Poettering" <lennart@poettering.net>,
"Mike Yuan" <me@yhndnzj.com>,
"Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>
Subject: Re: [PATCH 00/22] coredump: cleanups & pidfd extension
Date: Sun, 2 Nov 2025 18:03:54 +0100 [thread overview]
Message-ID: <20251102170353.GA3837@redhat.com> (raw)
In-Reply-To: <20251028-work-coredump-signal-v1-0-ca449b7b7aa0@kernel.org>
On 10/28, Christian Brauner wrote:
>
> Christian Brauner (22):
> pidfs: use guard() for task_lock
> pidfs: fix PIDFD_INFO_COREDUMP handling
> pidfs: add missing PIDFD_INFO_SIZE_VER1
> pidfs: add missing BUILD_BUG_ON() assert on struct pidfd_info
> pidfd: add a new supported_mask field
> pidfs: prepare to drop exit_info pointer
> pidfs: drop struct pidfs_exit_info
> pidfs: expose coredump signal
I don't think these changes need my review... but FWIW, I see nothing
wrong in 1-8. For 1-8:
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2025-11-02 17:06 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 8:45 [PATCH 00/22] coredump: cleanups & pidfd extension Christian Brauner
2025-10-28 8:45 ` [PATCH 01/22] pidfs: use guard() for task_lock Christian Brauner
2025-11-03 15:19 ` Alexander Mikhalitsyn
2025-10-28 8:45 ` [PATCH 02/22] pidfs: fix PIDFD_INFO_COREDUMP handling Christian Brauner
2025-11-03 15:35 ` Alexander Mikhalitsyn
2025-10-28 8:45 ` [PATCH 03/22] pidfs: add missing PIDFD_INFO_SIZE_VER1 Christian Brauner
2025-11-03 15:36 ` Alexander Mikhalitsyn
2025-10-28 8:45 ` [PATCH 04/22] pidfs: add missing BUILD_BUG_ON() assert on struct pidfd_info Christian Brauner
2025-11-03 15:36 ` Alexander Mikhalitsyn
2025-10-28 8:45 ` [PATCH 05/22] pidfd: add a new supported_mask field Christian Brauner
2025-11-03 15:38 ` Alexander Mikhalitsyn
2025-10-28 8:45 ` [PATCH 06/22] pidfs: prepare to drop exit_info pointer Christian Brauner
2025-11-03 15:47 ` Alexander Mikhalitsyn
2025-10-28 8:45 ` [PATCH 07/22] pidfs: drop struct pidfs_exit_info Christian Brauner
2025-11-04 8:45 ` Alexander Mikhalitsyn
2025-10-28 8:45 ` [PATCH 08/22] pidfs: expose coredump signal Christian Brauner
2025-11-04 8:45 ` Alexander Mikhalitsyn
2025-10-28 8:45 ` [PATCH 09/22] selftests/pidfd: update pidfd header Christian Brauner
2025-11-04 8:52 ` Alexander Mikhalitsyn
2025-10-28 8:45 ` [PATCH 10/22] selftests/pidfd: add first supported_mask test Christian Brauner
2025-11-04 8:53 ` Alexander Mikhalitsyn
2025-10-28 8:45 ` [PATCH 11/22] selftests/pidfd: add second " Christian Brauner
2025-11-04 8:53 ` Alexander Mikhalitsyn
2025-10-28 8:45 ` [PATCH 12/22] selftests/coredump: split out common helpers Christian Brauner
2025-11-04 9:11 ` Alexander Mikhalitsyn
2025-10-28 8:45 ` [PATCH 13/22] selftests/coredump: split out coredump socket tests Christian Brauner
2025-11-04 9:11 ` Alexander Mikhalitsyn
2025-10-28 8:45 ` [PATCH 14/22] selftests/coredump: fix userspace client detection Christian Brauner
2025-11-04 9:12 ` Alexander Mikhalitsyn
2025-10-28 8:46 ` [PATCH 15/22] selftests/coredump: fix userspace coredump " Christian Brauner
2025-11-04 9:12 ` Alexander Mikhalitsyn
2025-10-28 8:46 ` [PATCH 16/22] selftests/coredump: handle edge-triggered epoll correctly Christian Brauner
2025-11-04 9:12 ` Alexander Mikhalitsyn
2025-10-28 8:46 ` [PATCH 17/22] selftests/coredump: add debug logging to test helpers Christian Brauner
2025-11-04 9:13 ` Alexander Mikhalitsyn
2025-10-28 8:46 ` [PATCH 18/22] selftests/coredump: add debug logging to coredump socket tests Christian Brauner
2025-11-04 9:13 ` Alexander Mikhalitsyn
2025-10-28 8:46 ` [PATCH 19/22] selftests/coredump: add debug logging to coredump socket protocol tests Christian Brauner
2025-11-04 9:13 ` Alexander Mikhalitsyn
2025-10-28 8:46 ` [PATCH 20/22] selftests/coredump: ignore ENOSPC errors Christian Brauner
2025-11-04 9:18 ` Alexander Mikhalitsyn
2025-10-28 8:46 ` [PATCH 21/22] selftests/coredump: add first PIDFD_INFO_COREDUMP_SIGNAL test Christian Brauner
2025-11-04 9:18 ` Alexander Mikhalitsyn
2025-10-28 8:46 ` [PATCH 22/22] selftests/coredump: add second " Christian Brauner
2025-11-04 9:19 ` Alexander Mikhalitsyn
2025-11-02 17:03 ` Oleg Nesterov [this message]
2025-11-04 21:00 ` [PATCH 00/22] coredump: cleanups & pidfd extension Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251102170353.GA3837@redhat.com \
--to=oleg@redhat.com \
--cc=alexander@mihalicyn.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=lennart@poettering.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.boccassi@gmail.com \
--cc=me@yhndnzj.com \
--cc=viro@zeniv.linux.org.uk \
--cc=watanabe.yu+github@gmail.com \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.