From: Jakub Kicinski <kuba@kernel.org>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Wen Gu <guwen@linux.alibaba.com>,
Philo Lu <lulie@linux.alibaba.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Lukas Bulwahn <lukas.bulwahn@redhat.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Vivian Wang <wangruikang@iscas.ac.cn>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>,
Dust Li <dust.li@linux.alibaba.com>
Subject: Re: [PATCH net-next v9 1/5] eea: introduce PCI framework
Date: Mon, 3 Nov 2025 18:23:30 -0800 [thread overview]
Message-ID: <20251103182330.4ba2e102@kernel.org> (raw)
In-Reply-To: <20251029080145.18967-2-xuanzhuo@linux.alibaba.com>
On Wed, 29 Oct 2025 16:01:41 +0800 Xuan Zhuo wrote:
> +static int __eea_pci_probe(struct pci_dev *pci_dev,
> + struct eea_pci_device *ep_dev)
> +{
> + int err;
> +
> + pci_set_drvdata(pci_dev, ep_dev);
> +
> + err = eea_pci_setup(pci_dev, ep_dev);
> + if (err)
> + goto err_setup;
> +
> + err = eea_init_device(&ep_dev->edev);
> + if (err)
> + goto err_register;
> +
> + return 0;
> +
> +err_register:
> + eea_pci_release_resource(ep_dev);
> +
> +err_setup:
> + kfree(ep_dev);
> + return err;
Please name the jump labels after the target (usually first action they
perform).
--
pw-bot: cr
next prev parent reply other threads:[~2025-11-04 2:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 8:01 [PATCH net-next v9 0/5] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor Xuan Zhuo
2025-10-29 8:01 ` [PATCH net-next v9 1/5] eea: introduce PCI framework Xuan Zhuo
2025-11-04 2:23 ` Jakub Kicinski [this message]
2025-10-29 8:01 ` [PATCH net-next v9 2/5] eea: introduce ring and descriptor structures Xuan Zhuo
2025-11-04 2:24 ` Jakub Kicinski
2025-10-29 8:01 ` [PATCH net-next v9 3/5] eea: probe the netdevice and create adminq Xuan Zhuo
2025-10-29 8:01 ` [PATCH net-next v9 4/5] eea: create/destroy rx,tx queues for netdevice open and stop Xuan Zhuo
2025-10-29 8:01 ` [PATCH net-next v9 5/5] eea: introduce ethtool support Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103182330.4ba2e102@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=guwen@linux.alibaba.com \
--cc=lorenzo@kernel.org \
--cc=lukas.bulwahn@redhat.com \
--cc=lulie@linux.alibaba.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=troy.mitchell@linux.spacemit.com \
--cc=vadim.fedorenko@linux.dev \
--cc=wangruikang@iscas.ac.cn \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.