All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Fan Gong <gongfan1@huawei.com>
Cc: Zhu Yikai <zhuyikai1@h-partners.com>, <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>, <Markus.Elfring@web.de>,
	<pavan.chebbi@broadcom.com>, <linux-kernel@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, luosifu <luosifu@huawei.com>,
	Xin Guo <guoxin09@huawei.com>,
	Shen Chenyang <shenchenyang1@hisilicon.com>,
	Zhou Shuai <zhoushuai28@huawei.com>, Wu Like <wulike1@huawei.com>,
	Shi Jing <shijing34@huawei.com>,
	Luo Yang <luoyang82@h-partners.com>,
	Meny Yossefi <meny.yossefi@huawei.com>,
	Gur Stavi <gur.stavi@huawei.com>
Subject: Re: [PATCH net-next v04 0/5] net: hinic3: PF initialization
Date: Mon, 3 Nov 2025 18:29:09 -0800	[thread overview]
Message-ID: <20251103182909.1706a5a4@kernel.org> (raw)
In-Reply-To: <cover.1761711549.git.zhuyikai1@h-partners.com>

On Wed, 29 Oct 2025 14:16:24 +0800 Fan Gong wrote:
> This is [1/3] part of hinic3 Ethernet driver second submission.
> With this patch hinic3 becomes a complete Ethernet driver with
> pf and vf.
> 
> The driver parts contained in this patch:
> Add support for PF framework based on the VF code.
> Add PF management interfaces to communicate with HW.
> Add ops to configure NIC features.
> Support mac filter to unicast and multicast.
> Add netdev notifier.

Please try to wrap the code at 80 characters.
checkpatch --max-line-length=80
almost all the violations in this series can be easily fixed.

For function definitions you can put the return type on separate line:

static struct hinic3_mac_filter *
hinic3_mac_filter_entry_clone(const struct hinic3_mac_filter *src)
-- 
pw-bot: cr

      parent reply	other threads:[~2025-11-04  2:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29  6:16 [PATCH net-next v04 0/5] net: hinic3: PF initialization Fan Gong
2025-10-29  6:16 ` [PATCH net-next v04 1/5] hinic3: Add PF framework Fan Gong
2025-10-29  6:16 ` [PATCH net-next v04 2/5] hinic3: Add PF management interfaces Fan Gong
2025-11-05  8:25   ` Simon Horman
2025-10-29  6:16 ` [PATCH net-next v04 3/5] hinic3: Add NIC configuration ops Fan Gong
2025-11-05  9:14   ` Simon Horman
2025-10-29  6:16 ` [PATCH net-next v04 4/5] hinic3: Add mac filter ops Fan Gong
2025-10-29  6:16 ` [PATCH net-next v04 5/5] hinic3: Add netdev register interfaces Fan Gong
2025-11-05  9:16   ` Simon Horman
2025-11-04  2:29 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251103182909.1706a5a4@kernel.org \
    --to=kuba@kernel.org \
    --cc=Markus.Elfring@web.de \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gongfan1@huawei.com \
    --cc=guoxin09@huawei.com \
    --cc=gur.stavi@huawei.com \
    --cc=horms@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luosifu@huawei.com \
    --cc=luoyang82@h-partners.com \
    --cc=meny.yossefi@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    --cc=shenchenyang1@hisilicon.com \
    --cc=shijing34@huawei.com \
    --cc=wulike1@huawei.com \
    --cc=zhoushuai28@huawei.com \
    --cc=zhuyikai1@h-partners.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.