From: Greg KH <gregkh@linuxfoundation.org>
To: Badhri Jagan Sridharan <badhri@google.com>
Cc: heikki.krogerus@linux.intel.com, amitsd@google.com,
kyletso@google.com, rdbabiera@google.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 0/1] TCPM logbuffer wraparound
Date: Mon, 3 Nov 2025 14:27:37 +0900 [thread overview]
Message-ID: <2025110336-hummus-stank-e5ff@gregkh> (raw)
In-Reply-To: <20251103052450.1028813-1-badhri@google.com>
On Mon, Nov 03, 2025 at 05:24:49AM +0000, Badhri Jagan Sridharan wrote:
> This is a follow up on a previous discussion:
> https://lore.kernel.org/lkml/20230410073134.488762-1-badhri@google.com/.
>
> With this change, TCPM log buffer will now wrap around when full and
> will not self-clear upon being read (dumped). A Kconfig option and a
> corresponding debugfs file node are introduced to allow opt-in back to
> the previous, non-wrapping, self-clearing behavior if required.
> This is an interim step while TCPM logging infrastructure is migrated
> to the standard event trace system.
Ick, no, let's just move to the standard trace format instead. That
should be much simpler and get rid of custom user/kernel apis and
Kconfig options. Overall you should end up removing a bunch of code
instead of adding new complexity like this.
thanks,
greg k-h
prev parent reply other threads:[~2025-11-03 6:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 5:24 [PATCH v2 0/1] TCPM logbuffer wraparound Badhri Jagan Sridharan
2025-11-03 5:24 ` [PATCH v2 1/1] tcpm: Wraparound tcpm log and dont clear them when read Badhri Jagan Sridharan
2025-11-03 5:27 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025110336-hummus-stank-e5ff@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=amitsd@google.com \
--cc=badhri@google.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rdbabiera@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.