From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, "Donald Hunter" <donald.hunter@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Jan Stancek" <jstancek@redhat.com>,
"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
"Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Shuah Khan" <shuah@kernel.org>,
"Ido Schimmel" <idosch@nvidia.com>,
"Guillaume Nault" <gnault@redhat.com>,
"Petr Machata" <petrm@nvidia.com>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] netlink: specs: update rt-rule src/dst attribute types to support IPv4 addresses
Date: Tue, 4 Nov 2025 16:48:04 -0800 [thread overview]
Message-ID: <20251104164804.540a9b8d@kernel.org> (raw)
In-Reply-To: <aQnG8IYsY3oyYekf@fedora>
On Tue, 4 Nov 2025 09:27:12 +0000 Hangbin Liu wrote:
> On Wed, Oct 29, 2025 at 04:37:42PM -0700, Jakub Kicinski wrote:
> > On Wed, 29 Oct 2025 08:22:44 +0000 Hangbin Liu wrote:
> > > -
> > > name: dst
> > > - type: u32
> > > + type: binary
> > > + display-hint: ipv4
> > > -
> > > name: src
> > > - type: u32
> > > + type: binary
> > > + display-hint: ipv4
> >
> > This will be annoying For C / C++, and you didn't set the max len
> > so I think we'll also have to malloc each time. Do we not support
> > display-hint for scalars?
>
> Hi Jakub,
>
> I just realize that most of the address/src/dst in rt-addr/route are
> dual stack. The same with FRA_DST. We can't simply change binary to u32.
> So can we keep this u32 -> binary change?
Ah, should have looked at more context..
Yes, and in that case without the display-hint?
next prev parent reply other threads:[~2025-11-05 0:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 8:22 [PATCH net-next 0/3] Add YNL test framework and library improvements Hangbin Liu
2025-10-29 8:22 ` [PATCH net-next 1/3] tools: ynl: Add MAC address parsing support Hangbin Liu
2025-10-29 8:22 ` [PATCH net-next 2/3] netlink: specs: update rt-rule src/dst attribute types to support IPv4 addresses Hangbin Liu
2025-10-29 23:37 ` Jakub Kicinski
2025-10-30 6:35 ` Hangbin Liu
2025-10-30 15:34 ` Jakub Kicinski
2025-11-04 9:27 ` Hangbin Liu
2025-11-05 0:48 ` Jakub Kicinski [this message]
2025-11-05 7:55 ` Hangbin Liu
2025-11-06 0:13 ` Jakub Kicinski
2025-11-06 2:34 ` Hangbin Liu
2025-11-06 14:41 ` Jakub Kicinski
2025-11-06 15:07 ` Asbjørn Sloth Tønnesen
2025-11-10 3:12 ` Hangbin Liu
2025-10-29 8:22 ` [PATCH net-next 3/3] selftests: net: add YNL test framework Hangbin Liu
2025-10-29 23:41 ` Jakub Kicinski
2025-10-30 6:00 ` Hangbin Liu
2025-10-30 15:39 ` Jakub Kicinski
2025-10-31 1:48 ` Hangbin Liu
2025-10-31 18:24 ` Jakub Kicinski
2025-11-03 5:12 ` Hangbin Liu
2025-11-04 0:05 ` Jakub Kicinski
2025-11-04 0:48 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251104164804.540a9b8d@kernel.org \
--to=kuba@kernel.org \
--cc=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jstancek@redhat.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.