From: Rosen Penev <rosenp@gmail.com>
To: dmaengine@vger.kernel.org
Cc: Vinod Koul <vkoul@kernel.org>, linux-kernel@vger.kernel.org (open list)
Subject: [PATCHv4 dmaengine 1/2] dmaengine: mv_xor: use devm_platform_ioremap_resource
Date: Wed, 5 Nov 2025 13:03:16 -0800 [thread overview]
Message-ID: <20251105210317.18215-2-rosenp@gmail.com> (raw)
In-Reply-To: <20251105210317.18215-1-rosenp@gmail.com>
Simplifies probe slightly by removing explicit struct resource pointers
and platform_get_resource calls.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/dma/mv_xor.c | 23 ++++++-----------------
1 file changed, 6 insertions(+), 17 deletions(-)
diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
index 5e8386296046..3597ad8d1220 100644
--- a/drivers/dma/mv_xor.c
+++ b/drivers/dma/mv_xor.c
@@ -1309,7 +1309,6 @@ static int mv_xor_probe(struct platform_device *pdev)
const struct mbus_dram_target_info *dram;
struct mv_xor_device *xordev;
struct mv_xor_platform_data *pdata = dev_get_platdata(&pdev->dev);
- struct resource *res;
unsigned int max_engines, max_channels;
int i, ret;
@@ -1319,23 +1318,13 @@ static int mv_xor_probe(struct platform_device *pdev)
if (!xordev)
return -ENOMEM;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -ENODEV;
+ xordev->xor_base = devm_platform_ioremap_resource(pdev, 0);
+ if (IS_ERR(xordev->xor_base))
+ return PTR_ERR(xordev->xor_base);
- xordev->xor_base = devm_ioremap(&pdev->dev, res->start,
- resource_size(res));
- if (!xordev->xor_base)
- return -EBUSY;
-
- res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
- if (!res)
- return -ENODEV;
-
- xordev->xor_high_base = devm_ioremap(&pdev->dev, res->start,
- resource_size(res));
- if (!xordev->xor_high_base)
- return -EBUSY;
+ xordev->xor_high_base = devm_platform_ioremap_resource(pdev, 1);
+ if (IS_ERR(xordev->xor_high_base))
+ return PTR_ERR(xordev->xor_high_base);
platform_set_drvdata(pdev, xordev);
--
2.51.2
next prev parent reply other threads:[~2025-11-05 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 21:03 [PATCHv4 dmaengine 0/2] mv_xor: some devm cleanups Rosen Penev
2025-11-05 21:03 ` Rosen Penev [this message]
2025-11-05 21:03 ` [PATCHv4 dmaengine 2/2] dmaengine: mv_xor: use devm_clk_get_optional_enabled Rosen Penev
2025-12-23 11:07 ` [PATCHv4 dmaengine 0/2] mv_xor: some devm cleanups Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105210317.18215-2-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.