From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: broonie@kernel.org
Cc: vkoul@kernel.org, yung-chuan.liao@linux.intel.com,
pierre-louis.bossart@linux.dev, peter.ujfalusi@linux.intel.com,
shumingf@realtek.com, lgirdwood@gmail.com,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com
Subject: [PATCH v3 07/13] ASoC: SDCA: Use helper macros for control identification
Date: Thu, 6 Nov 2025 11:44:16 +0000 [thread overview]
Message-ID: <20251106114422.906370-8-ckeepax@opensource.cirrus.com> (raw)
In-Reply-To: <20251106114422.906370-1-ckeepax@opensource.cirrus.com>
We have the SDCA_CTL_TYPE helper macros, we should use them when
identifying specific controls to simplify the code a little.
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
No changes since v2.
sound/soc/sdca/sdca_interrupts.c | 36 +++++++++++++-------------------
1 file changed, 14 insertions(+), 22 deletions(-)
diff --git a/sound/soc/sdca/sdca_interrupts.c b/sound/soc/sdca/sdca_interrupts.c
index a18ec9dd3398b..8f6a2adfb6fbe 100644
--- a/sound/soc/sdca/sdca_interrupts.c
+++ b/sound/soc/sdca/sdca_interrupts.c
@@ -456,11 +456,8 @@ int sdca_irq_populate_early(struct device *dev, struct regmap *regmap,
else if (!interrupt)
continue;
- switch (entity->type) {
- case SDCA_ENTITY_TYPE_XU:
- if (control->sel != SDCA_CTL_XU_FDL_CURRENTOWNER)
- break;
-
+ switch (SDCA_CTL_TYPE(entity->type, control->sel)) {
+ case SDCA_CTL_TYPE_S(XU, FDL_CURRENTOWNER):
ret = sdca_irq_data_populate(dev, regmap, NULL,
function, entity,
control, interrupt);
@@ -534,27 +531,22 @@ int sdca_irq_populate(struct sdca_function_data *function,
handler = base_handler;
- switch (entity->type) {
- case SDCA_ENTITY_TYPE_ENTITY_0:
- if (control->sel == SDCA_CTL_ENTITY_0_FUNCTION_STATUS)
- handler = function_status_handler;
+ switch (SDCA_CTL_TYPE(entity->type, control->sel)) {
+ case SDCA_CTL_TYPE_S(ENTITY_0, FUNCTION_STATUS):
+ handler = function_status_handler;
break;
- case SDCA_ENTITY_TYPE_GE:
- if (control->sel == SDCA_CTL_GE_DETECTED_MODE)
- handler = detected_mode_handler;
+ case SDCA_CTL_TYPE_S(GE, DETECTED_MODE):
+ handler = detected_mode_handler;
break;
- case SDCA_ENTITY_TYPE_XU:
- if (control->sel == SDCA_CTL_XU_FDL_CURRENTOWNER) {
- ret = sdca_fdl_alloc_state(interrupt);
- if (ret)
- return ret;
+ case SDCA_CTL_TYPE_S(XU, FDL_CURRENTOWNER):
+ ret = sdca_fdl_alloc_state(interrupt);
+ if (ret)
+ return ret;
- handler = fdl_owner_handler;
- }
+ handler = fdl_owner_handler;
break;
- case SDCA_ENTITY_TYPE_HIDE:
- if (control->sel == SDCA_CTL_HIDE_HIDTX_CURRENTOWNER)
- handler = hid_handler;
+ case SDCA_CTL_TYPE_S(HIDE, HIDTX_CURRENTOWNER):
+ handler = hid_handler;
break;
default:
break;
--
2.47.3
next prev parent reply other threads:[~2025-11-06 11:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 11:44 [PATCH v3 00/13] Add SDCA class driver Charles Keepax
2025-11-06 11:44 ` [PATCH v3 01/13] ASoC: SDCA: Remove duplicated module macros Charles Keepax
2025-11-06 11:44 ` [PATCH v3 02/13] ASoC: SDCA: Fix missing dash in HIDE DisCo property Charles Keepax
2025-11-06 11:44 ` [PATCH v3 03/13] ASoC: SDCA: Add missing forward declaration in header Charles Keepax
2025-11-06 11:44 ` [PATCH v3 04/13] ASoC: SDCA: Correct FDL locking in sdca_fdl_process() Charles Keepax
2025-11-06 11:44 ` [PATCH v3 05/13] ASoC: SDCA: Add comment for function reset polling Charles Keepax
2025-11-06 11:44 ` [PATCH v3 06/13] ASoC: SDCA: Move most of the messages from info to debug Charles Keepax
2025-11-06 11:44 ` Charles Keepax [this message]
2025-11-06 11:44 ` [PATCH v3 08/13] ASoC: SDCA: Factor out helper to process Control defaults Charles Keepax
2025-11-06 11:44 ` [PATCH v3 09/13] ASoC: SDCA: Populate regmap cache for readable Controls Charles Keepax
2025-11-06 11:44 ` [PATCH v3 10/13] ASoC: SDCA: Add helper to write initialization writes Charles Keepax
2025-11-06 11:44 ` [PATCH v3 11/13] ASoC: SDCA: add function devices Charles Keepax
2025-11-06 11:44 ` [PATCH v3 12/13] ASoC: SDCA: Add basic SDCA class driver Charles Keepax
2025-11-06 11:44 ` [PATCH v3 13/13] ASoC: SDCA: Add basic SDCA function driver Charles Keepax
2025-11-17 6:13 ` [PATCH v3 00/13] Add SDCA class driver Liao, Bard
2025-11-19 11:53 ` Maciej Strozek
2025-11-19 13:59 ` Péter Ujfalusi
2025-11-19 15:02 ` Richard Fitzgerald
2025-11-21 22:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251106114422.906370-8-ckeepax@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=shumingf@realtek.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.