From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-block@vger.kernel.org, hch@lst.de, axboe@kernel.dk,
dlemoal@kernel.org, hans.holmberg@wdc.com,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv2 3/4] null_blk: single kmap per bio segment
Date: Thu, 6 Nov 2025 12:53:41 +0100 [thread overview]
Message-ID: <20251106115341.GC2002@lst.de> (raw)
In-Reply-To: <20251106015447.1372926-4-kbusch@meta.com>
On Wed, Nov 05, 2025 at 05:54:46PM -0800, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Rather than kmap the the request bio segment for each sector, do
> the mapping just once.
This looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Although I'd still prefer to pass the bvec down as far as possible..
next prev parent reply other threads:[~2025-11-06 11:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 1:54 [PATCHv2 0/4] null_blk: relaxed memory alignments Keith Busch
2025-11-06 1:54 ` [PATCHv2 1/4] null_blk: simplify copy_from_nullb Keith Busch
2025-11-06 3:51 ` Chaitanya Kulkarni
2025-11-06 4:12 ` Damien Le Moal
2025-11-06 10:48 ` Johannes Thumshirn
2025-11-06 11:51 ` Christoph Hellwig
2025-11-06 1:54 ` [PATCHv2 2/4] null_blk: consistently use blk_status_t Keith Busch
2025-11-06 3:52 ` Chaitanya Kulkarni
2025-11-06 4:13 ` Damien Le Moal
2025-11-06 10:52 ` Johannes Thumshirn
2025-11-06 11:52 ` Christoph Hellwig
2025-11-06 1:54 ` [PATCHv2 3/4] null_blk: single kmap per bio segment Keith Busch
2025-11-06 3:58 ` Chaitanya Kulkarni
2025-11-06 4:26 ` Damien Le Moal
2025-11-06 11:22 ` Johannes Thumshirn
2025-11-06 11:53 ` Christoph Hellwig [this message]
2025-11-06 1:54 ` [PATCHv2 4/4] null_blk: allow byte aligned memory offsets Keith Busch
2025-11-06 4:09 ` Chaitanya Kulkarni
2025-11-06 4:31 ` Damien Le Moal
2025-11-06 4:40 ` Keith Busch
2025-11-06 11:23 ` Johannes Thumshirn
2025-11-06 12:01 ` Christoph Hellwig
2025-11-06 15:24 ` Keith Busch
2025-11-06 15:42 ` Johannes Thumshirn
2025-11-06 15:43 ` hch
2025-11-06 4:11 ` [PATCHv2 0/4] null_blk: relaxed memory alignments Damien Le Moal
2025-11-06 8:35 ` Hans Holmberg
2025-11-06 23:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251106115341.GC2002@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.