From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <stfomichev@gmail.com>
Cc: davem@davemloft.net, donald.hunter@gmail.com,
netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, sdf@fomichev.me,
joe@dama.to, jstancek@redhat.com
Subject: Re: [PATCH net-next 2/5] tools: ynltool: create skeleton for the C command
Date: Thu, 6 Nov 2025 14:24:47 -0800 [thread overview]
Message-ID: <20251106142447.75250c87@kernel.org> (raw)
In-Reply-To: <aQzOs-0tFbGJOwgL@mini-arch>
On Thu, 6 Nov 2025 08:37:07 -0800 Stanislav Fomichev wrote:
> > +static int do_version(int argc __attribute__((unused)),
> > + char **argv __attribute__((unused)))
> > +{
> > + if (json_output) {
> > + jsonw_start_object(json_wtr);
> > + jsonw_name(json_wtr, "version");
> > + jsonw_printf(json_wtr, "\"0.1.0\"");
>
> Any reason not to start with something like commit 4bfe3bd3cc35
> ("tools/bpftool: use version from the kernel source tree") here?
> Otherwise I doubt 0.1.0 will be changed ever.
Ah, thanks a lot for the pointer! I grepped bpftool for kernelversion
but somehow it eluded me..
--
pw-bot: cr
next prev parent reply other threads:[~2025-11-06 22:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 23:23 [PATCH net-next 0/5] tools: ynl: turn the page-pool sample into a real tool Jakub Kicinski
2025-11-04 23:23 ` [PATCH net-next 1/5] netlink: specs: netdev add missing stats to qstat-get Jakub Kicinski
2025-11-04 23:23 ` [PATCH net-next 2/5] tools: ynltool: create skeleton for the C command Jakub Kicinski
2025-11-06 16:37 ` Stanislav Fomichev
2025-11-06 22:24 ` Jakub Kicinski [this message]
2025-11-04 23:23 ` [PATCH net-next 3/5] tools: ynltool: add page-pool stats Jakub Kicinski
2025-11-04 23:23 ` [PATCH net-next 4/5] tools: ynltool: add qstats support Jakub Kicinski
2025-11-04 23:23 ` [PATCH net-next 5/5] tools: ynltool: add traffic distribution balance Jakub Kicinski
2025-11-06 15:02 ` [PATCH net-next 0/5] tools: ynl: turn the page-pool sample into a real tool Jakub Kicinski
2025-11-06 16:34 ` Stanislav Fomichev
2025-11-07 16:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251106142447.75250c87@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=joe@dama.to \
--cc=jstancek@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=stfomichev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.