From: Krzysztof Kozlowski <krzk@kernel.org>
To: Swamil Jain <s-jain1@ti.com>
Cc: jyri.sarha@iki.fi, tomi.valkeinen@ideasonboard.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
nm@ti.com, vigneshr@ti.com, kristo@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org,
louis.chauvet@bootlin.com, aradhya.bhatia@linux.dev,
devarsht@ti.com, praneeth@ti.com, h-shenoy@ti.com,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2 5/5] drm/tidss: Fix sampling edge configuration
Date: Fri, 7 Nov 2025 08:59:09 +0100 [thread overview]
Message-ID: <20251107-sparkling-brown-bison-be7fca@kuoka> (raw)
In-Reply-To: <20251106141227.899054-6-s-jain1@ti.com>
On Thu, Nov 06, 2025 at 07:42:27PM +0530, Swamil Jain wrote:
>
> void dispc_vp_enable(struct dispc_device *dispc, u32 hw_videoport)
> @@ -3003,6 +3009,14 @@ int dispc_init(struct tidss_device *tidss)
>
> dispc_init_errata(dispc);
>
> + dispc->clk_ctrl = syscon_regmap_lookup_by_phandle_optional(tidss->dev->of_node,
> + "ti,clk-ctrl");
> + if (IS_ERR(dispc->clk_ctrl)) {
> + r = dev_err_probe(dispc->dev, PTR_ERR(dispc->clk_ctrl),
> + "DISPC: syscon_regmap_lookup_by_phandle failed.\n");
> + return r;
NAK. Read previous comments instead of silently ignoring them.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-07 7:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 14:12 [RESEND PATCH v2 0/5] drm/tidss: Fixes data edge sampling on AM62X and AM62A Swamil Jain
2025-11-06 14:12 ` [RESEND PATCH v2 1/5] dt-bindings: display: ti,am65x-dss: Add clk property for data edge synchronization Swamil Jain
2025-11-06 14:12 ` [RESEND PATCH v2 1/5] dt-bindings: display: ti, am65x-dss: " Swamil Jain
2025-11-07 7:54 ` [RESEND PATCH v2 1/5] dt-bindings: display: ti,am65x-dss: " Krzysztof Kozlowski
2025-11-07 7:56 ` Krzysztof Kozlowski
2025-11-07 7:56 ` [RESEND PATCH v2 1/5] dt-bindings: display: ti, am65x-dss: " Krzysztof Kozlowski
2025-11-06 14:12 ` [RESEND PATCH v2 2/5] dt-bindings: mfd: syscon: Add ti,am625-dss-clk-ctrl Swamil Jain
2025-11-06 14:12 ` [RESEND PATCH v2 2/5] dt-bindings: mfd: syscon: Add ti, am625-dss-clk-ctrl Swamil Jain
2025-11-07 7:50 ` [RESEND PATCH v2 2/5] dt-bindings: mfd: syscon: Add ti,am625-dss-clk-ctrl Krzysztof Kozlowski
2025-11-07 7:56 ` Krzysztof Kozlowski
2025-11-06 14:12 ` [RESEND PATCH v2 3/5] arm64: dts: ti: k3-am62-main: Add tidss clk-ctrl property Swamil Jain
2025-11-07 7:57 ` Krzysztof Kozlowski
2025-11-06 14:12 ` [RESEND PATCH v2 4/5] arm64: dts: ti: k3-am62a-main: " Swamil Jain
2025-11-07 7:58 ` Krzysztof Kozlowski
2025-11-06 14:12 ` [RESEND PATCH v2 5/5] drm/tidss: Fix sampling edge configuration Swamil Jain
2025-11-07 7:59 ` Krzysztof Kozlowski [this message]
2026-07-02 12:59 ` Leonardo Costa
2026-07-08 12:15 ` Swamil Jain
2026-07-06 10:57 ` [PATCH] drm/bridge: tc358768: Enforce input bus flags via atomic_check Leonardo Costa
2026-07-06 11:38 ` Leonardo Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107-sparkling-brown-bison-be7fca@kuoka \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=aradhya.bhatia@linux.dev \
--cc=conor+dt@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=h-shenoy@ti.com \
--cc=jyri.sarha@iki.fi \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nm@ti.com \
--cc=praneeth@ti.com \
--cc=robh@kernel.org \
--cc=s-jain1@ti.com \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.